Skip to content

fix(panic) fix client push panic #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2019
Merged

fix(panic) fix client push panic #134

merged 2 commits into from
Sep 7, 2019

Conversation

pshopper
Copy link
Contributor

Check error of http request creation

fix(panic) fix client push panic
d1668c3 
Check error of http request creation
@pshopper pshopper mentioned this pull request May 16, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 91.65% when pulling d1668c3 on pshopper:fix-client-push-panic into d5157a5 on sideshow:master.

@coveralls
Copy link

coveralls commented May 16, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 92.048% when pulling d3ee82d on pshopper:fix-client-push-panic into d5157a5 on sideshow:master.

@pshopper
Copy link
Contributor Author

@sideshow maybe time to merge?

@sideshow sideshow merged commit 4fbb779 into sideshow:master Sep 7, 2019
@sideshow
Copy link
Owner

sideshow commented Sep 7, 2019

This is great. Thanks for the PR

@sideshow sideshow mentioned this pull request Sep 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pshopper @coveralls @sideshow