Skip to content

Conversation

@DavidDeSloovere
Copy link
Contributor

πŸ”— Linked issue

nuxt-modules/i18n#2980

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

sendRedirect returns a promise and should be awaited

I have nuxt i18n that sets a cookie, but there is a conflict if await is not used.

I have patched this locally and the cookie specific error was gone.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

sendRedirect returns a promise and should be awaited

I have nuxt i18n that sets a cookie, but there is a conflict if await is not used.
@zoey-kaiser zoey-kaiser added p3 Minor issue bug A bug that needs to be resolved labels Jun 27, 2024
@zoey-kaiser zoey-kaiser merged commit ecf945f into sidebase:main Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A bug that needs to be resolved p3 Minor issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants