-
-
Notifications
You must be signed in to change notification settings - Fork 188
fix: properly disable getSession endpoint for local and refresh
#768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Armillus π Firstly, I love the PR title π. Thank you for pushing this change, and I apologize for the short delay. I had just run the CI checks on your PR and sadly there are some prepack issues. Could you please look into resolving these π€ |
|
Hi @zoey-kaiser, I'm glad you liked the title π No problem regarding the delay! |
They are indeed! Thank you so much! There is one small linting issue and otherwise I think we are good to go. Once we get this PR through, I will release a first RC of 0.8.0! |
|
Wonderful! I fixed linting issues as well, sorry for the slight inconvenience. |
getSession endpoint for local and refresh
|
Hi @Armillus π After testing this PR in 0.8.0, we decided to revert it. You can find a full explanation here: #781 (comment) |
π Linked issue
#761
β Type of change
π Description
The linked issue just covered half of the problem ; in the current form,
getSessioncannot be disabled, even with a configuration extracted from the documentation such as:It's not an issue while you're not calling it, except that it is called by
signInanyways, at least with thelocalandrefreshproviders. Eventually, it means that an unexpected HTTP request is sent, which on one hand is inefficient, and on the other hand throws an exception fromsignIn, thus making it fail.To fix those problems, this PR is applying the same strategy for
getSessionas forsignOut, in both the function implementation and the exported type.π Checklist