fix: don't send sign-in options in request payload #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#411
β Type of change
π Description
When using method
signIn(credentials, { callbackUrl: '/' })method withlocalorrefreshprovider, thecallbackUrland other options were sent to the server.As mentioned in #411 (comment), some servers can reject the request if the payload contains invalid parameters.
Those options are only used when the sign-in request is done, they shouldn't be sent to the server. They can be set directly in
credentialsdata if they have to.Flagged as breaking change because some options may have to be copied from
signInOptionstocredentials.π Checklist