feat: ✨ add flag to disable getSession after signIn on local / refresh provider #702

bitfactory-frank-spee · 2024-03-05T13:05:22Z

🔗 Linked issue

❓ Type of change

📖 Documentation (updates to the documentation, readme or JSdoc annotations)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality like performance)
✨ New feature (a non-breaking change that adds functionality)
🧹 Chore (updates to the build process or auxiliary tools and libraries)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

See issue for clarification. This adds a flag to the signInOptions named withSession which defaults to true. This makes sure this will be backwards compatible. When withSession === false the getSession method will not be called.

This also includes a bug fix (681fdb0) where refresh was not equal to local provider.

📝 Checklist

I have linked an issue or discussion.
I have added tests (if possible).
I have updated the documentation accordingly.

NOTE: this documentation mentioned withGetSession before and not withSession as decided to be the name later.

…provider

phoenix-ru · 2024-03-07T09:30:35Z

Hi @bitfactory-frank-spee , thanks for your contribution, it looks good to me.

I will come back to it after #694 , so that we can ensure that it's functionally good.

phoenix-ru · 2024-04-04T11:27:08Z

@bitfactory-frank-spee Could you please sync your PR with the current main?

phoenix-ru · 2024-04-18T14:52:06Z

bump @bitfactory-frank-spee

bitfactory-frank-spee · 2024-04-25T12:42:55Z

@phoenix-ru I will update it this week 👍

bitfactory-frank-spee · 2024-04-25T18:22:51Z

@bitfactory-frank-spee Could you please sync your PR with the current main?

Done 🚀

zoey-kaiser

Hi @bitfactory-frank-spee 👋

Very close to being done! I have one minor renaming request and then we should be good to go, to release this in 0.8!

docs/content/3.application-side/2.session-access-and-management.md

…n-in

zoey-kaiser · 2024-07-05T11:37:50Z

Hi @bitfactory-frank-spee 👋

We just released 0.8.0, so I would begin looking into getting this PR merged in the next release. Could you please merge main and we can then do a final round of reviews 😊

zoey-kaiser

Just some typings missing 😊

src/runtime/composables/local/useAuth.ts

zoey-kaiser · 2024-09-18T17:29:47Z

Closing as this PR has gone stale. If someone else would like to take over the PR, feel free to fork the fixes and open a new PR 😊

Mucaccino · 2024-10-22T03:15:02Z

I need this. Really this was gone stale?

bitfactory-frank-spee · 2024-10-22T06:24:22Z

I need this. Really this was gone stale?

Ahh, I now see that I needed to respond to this, and that I didn't. I have now: #702 (comment)

bitfactory-frank-spee · 2024-11-05T08:40:29Z

I merged the current main into this PR and fixed the conflicts as the local and refresh provider are merged in the new release. I also fixed the documentation.

src/runtime/types.ts

pkg-pr-new · 2024-11-28T15:47:15Z

Open in Stackblitz

npm i https://pkg.pr.new/@sidebase/nuxt-auth@702

commit: 32f3e80

phoenix-ru

Hi @bitfactory-frank-spee , sorry for us not answering for a long time, I would take over the PR and make sure it's over the line :)

docs/guide/application-side/session-access.md

phoenix-ru · 2024-11-28T16:03:30Z

@bitfactory-frank-spee, unfortunately, I cannot directly commit to your PR (probably due to restrictions on your org).

I still checked it though and it seems to work, but I have several points

src/runtime/types.ts

bitfactory-frank-spee · 2024-11-29T12:24:03Z

Hi @bitfactory-frank-spee , sorry for us not answering for a long time, I would take over the PR and make sure it's over the line :)

No problem. I will check your comments today.

bitfactory-frank-spee · 2024-11-29T12:26:59Z

@bitfactory-frank-spee, unfortunately, I cannot directly commit to your PR (probably due to restrictions on your org).

I still checked it though and it seems to work, but I have several points

Ah that could be. I am sorry about that. I can probably not change that immediately. Next time I will use my personal account.

Co-authored-by: Marsel Shaikhin <[email protected]>

…hub.com/bitfactory-nl/nuxt-auth into feature/optional-get-session-on-sign-in

bitfactory-frank-spee · 2024-11-29T12:48:15Z

@phoenix-ru I fixed everything you asked. And updated this branch with the main branch.

addressed

phoenix-ru · 2024-12-19T15:04:12Z

Hi @bitfactory-frank-spee , extremely sorry for deprioritizing this for a long time! I will ask @zoey-kaiser if she's fine with squeezing this PR into the upcoming 0.10.0 release and merge asap

bitfactory-frank-spee · 2024-12-22T17:41:54Z

Hi @bitfactory-frank-spee , extremely sorry for deprioritizing this for a long time! I will ask @zoey-kaiser if she's fine with squeezing this PR into the upcoming 0.10.0 release and merge asap

Excellent! 🎉 🚀 Thanks for the help. Good luck with further releases.

bitfactory-frank-spee added 4 commits March 5, 2024 13:38

feat: ✨ add flag to disable getSession after signIn on local provider

b577d1f

feat: ✨ add flag to disable getSession after signIn on refresh provider

48deba6

docs: ✨ add flag to disable getSession after signIn on local/refresh …

3d10095

…provider

fix: 🐛 sync refresh provider redirect external with local provider

681fdb0

bitfactory-frank-spee mentioned this pull request Mar 5, 2024

feat: ✨ add flag to disable getSession after signIn on local / refresh provider #701

Closed

5 tasks

bitfactory-oussama-fadlaoui approved these changes Mar 5, 2024

View reviewed changes

zoey-kaiser linked an issue Mar 7, 2024 that may be closed by this pull request

feat: ✨ add flag to disable getSession after signIn on local / refresh provider #701

Closed

5 tasks

Merge branch 'main' into feature/optional-get-session-on-sign-in

e59026b

zoey-kaiser requested a review from phoenix-ru May 9, 2024 10:58

zoey-kaiser added enhancement An improvement that needs to be added provider-local An issue with the local provider provider-refresh An issue with the refresh provider labels May 9, 2024

zoey-kaiser requested changes May 22, 2024

View reviewed changes

docs/content/3.application-side/2.session-access-and-management.md Outdated Show resolved Hide resolved

refactor: ♻️ rename withGetSession boolean to withSession

ac9415f

bitfactory-frank-spee requested review from bitfactory-oussama-fadlaoui and zoey-kaiser June 7, 2024 06:48

Merge branch 'sidebase:main' into feature/optional-get-session-on-sig…

695b437

…n-in

zoey-kaiser previously requested changes Jul 5, 2024

View reviewed changes

src/runtime/composables/local/useAuth.ts Outdated Show resolved Hide resolved

zoey-kaiser closed this Sep 18, 2024

zoey-kaiser reopened this Oct 22, 2024

Merge branch 'main' into feature/optional-get-session-on-sign-in

14c2618

docs: 📝 add example to disable getSession with signIn local provider

d77805e

feat: 🏷️ add withSession flag to SecondarySignInOptions interface

930aae3

bitfactory-frank-spee commented Nov 5, 2024

View reviewed changes

src/runtime/types.ts Show resolved Hide resolved

phoenix-ru reviewed Nov 28, 2024

View reviewed changes

docs/guide/application-side/session-access.md Outdated Show resolved Hide resolved

phoenix-ru mentioned this pull request Nov 28, 2024

Change signUp signature to avoid tautology #948

Open

phoenix-ru reviewed Nov 28, 2024

View reviewed changes

src/runtime/types.ts Show resolved Hide resolved

src/runtime/types.ts Outdated Show resolved Hide resolved

bitfactory-frank-spee and others added 5 commits November 29, 2024 13:38

revert: style: 🎨 remove markdownlint md034 url change

7739fbc

docs: 📝 improve type documentation

87f5838

Co-authored-by: Marsel Shaikhin <[email protected]>

refactor: ♻️ rename withSession to callGetSession

156fd57

Merge branch 'feature/optional-get-session-on-sign-in' of https://git…

d5c28ef

…hub.com/bitfactory-nl/nuxt-auth into feature/optional-get-session-on-sign-in

Merge branch 'main' into feature/optional-get-session-on-sign-in

32f3e80

bitfactory-frank-spee requested review from phoenix-ru and zoey-kaiser November 29, 2024 12:49

phoenix-ru approved these changes Dec 19, 2024

View reviewed changes

zoey-kaiser approved these changes Dec 19, 2024

View reviewed changes

zoey-kaiser merged commit b5af548 into sidebase:main Dec 19, 2024
6 checks passed

bitfactory-frank-spee deleted the feature/optional-get-session-on-sign-in branch December 22, 2024 17:43

Uh oh!

feat: ✨ add flag to disable getSession after signIn on local / refresh provider #702

feat: ✨ add flag to disable getSession after signIn on local / refresh provider #702

Uh oh!

Conversation

bitfactory-frank-spee commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

❓ Type of change

📚 Description

📝 Checklist

Uh oh!

phoenix-ru commented Mar 7, 2024

Uh oh!

phoenix-ru commented Apr 4, 2024

Uh oh!

phoenix-ru commented Apr 18, 2024

Uh oh!

bitfactory-frank-spee commented Apr 25, 2024

Uh oh!

bitfactory-frank-spee commented Apr 25, 2024

Uh oh!

zoey-kaiser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zoey-kaiser commented Jul 5, 2024

Uh oh!

zoey-kaiser left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zoey-kaiser commented Sep 18, 2024

Uh oh!

Mucaccino commented Oct 22, 2024

Uh oh!

bitfactory-frank-spee commented Oct 22, 2024

Uh oh!

bitfactory-frank-spee commented Nov 5, 2024

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phoenix-ru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phoenix-ru commented Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bitfactory-frank-spee commented Nov 29, 2024

Uh oh!

bitfactory-frank-spee commented Nov 29, 2024

Uh oh!

bitfactory-frank-spee commented Nov 29, 2024

Uh oh!

phoenix-ru commented Dec 19, 2024

Uh oh!

Uh oh!

bitfactory-frank-spee commented Dec 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bitfactory-frank-spee commented Mar 5, 2024 •

edited

Loading

zoey-kaiser left a comment •

edited

Loading

pkg-pr-new bot commented Nov 28, 2024 •

edited

Loading

phoenix-ru commented Nov 28, 2024 •

edited

Loading