Conversation
- Print a half-block Unicode QR code below the Quick Connect URL on daemon startup; skipped silently when the terminal is too narrow or encodeQR throws — startup is never blocked by QR rendering - Fix relay keepalive timer race in connect.ts: capture the interval handle in a local `const timer` so a stale send failure from a prior connection cannot clear the active connection's timer - Add SBRP Ping every 45s in runMux (listen.ts) to keep the daemon's relay connection alive past the relay's 90s idle sweep - Add ADR-019 documenting trust policy defaults for both auth paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encodeQRthrows — startup is never blocked.runMuxto keep the daemon's relay connection alive past the relay's 90s idle sweep; cleared infinallyon disconnect.connect.ts— capture the interval handle in a localconst timerso a stale send failure from a prior connection cannot clear the active connection's timer;terminate()now clears explicitly before transport close."auto") for both QC and account auth paths and the future path to"pinned-only"onceexpectedFingerprintis plumbed through the account API.typesandexportsfields topackages/cli/package.jsonso the package shows the TypeScript icon on npm.QR output
Test plan
bun test packages/cli— QR width-guard andemitErrortests pass