Bump http-tansport, msf4j and siddhi #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riyafa
reviewed
Mar 11, 2019
component/src/main/java/org/wso2/extension/siddhi/io/websocket/sink/WebSocketSink.java
Outdated
Show resolved
Hide resolved
component/src/main/java/org/wso2/extension/siddhi/io/websocket/sink/WebSocketSink.java
Show resolved
Hide resolved
component/src/main/java/org/wso2/extension/siddhi/io/websocket/sink/WebSocketSink.java
Show resolved
Hide resolved
...rc/main/java/org/wso2/extension/siddhi/io/websocket/sink/WebSocketSinkHandshakeListener.java
Outdated
Show resolved
Hide resolved
...extension/siddhi/io/websocket/sink/websocketserver/WebSocketServerSinkConnectorListener.java
Outdated
Show resolved
Hide resolved
component/src/main/java/org/wso2/extension/siddhi/io/websocket/source/WebSocketSource.java
Outdated
Show resolved
Hide resolved
component/src/test/java/org/wso2/extension/siddhi/io/websocket/util/WebSocketEndpoint.java
Show resolved
Hide resolved
niveathika
changed the title
riyafa
approved these changes
Mar 12, 2019
mohanvive
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject to add SSL support.
Ref: wso2/transport-http#205
Goals
Use a secure connection when url is defined with WebSocket secure protocol.
Approach
Add truststore.path and truststore.password element in the @sink and @source annotation and connect to a WebSocket server in the secure protocol.
User stories
N/A
Release note
Add SSL support for WebSocket sink and source
Documentation
Added in the annotation of the java class
Training
N/A
Certification
N/A
Marketing
N/A
Automation tests
Security checks
Samples
Added in the java file
Related PRs
N/A
Migrations (if applicable)
If websocket sink/source with wss protocol is defined both truststore.path and truststore.password should be added in the definition
Test environment
JDK 1.8.0, Maven 3.5
Learning
N/A