Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test with xvnc #177

Merged
merged 2 commits into from
Jan 9, 2021
Merged

test with xvnc #177

merged 2 commits into from
Jan 9, 2021

Conversation

ponty
Copy link

@ponty ponty commented May 27, 2020

This test can catch bug #172 with travis or tox.

Error message:
builtins.TypeError: unsupported operand type(s) for &: 'str' and 'int'

https://travis-ci.org/github/ponty/vncdotool/jobs/691896577

@ponty ponty changed the title test wth xvnc test with xvnc May 27, 2020
@ponty ponty mentioned this pull request May 27, 2020
Closed
sibson
sibson approved these changes Dec 26, 2020
View reviewed changes
Copy link
Owner

@sibson sibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. If I'm understanding correctly this is more of a functional test than a unit test. If so can we move to tests/functional to ensure we keep the unit tests running quickly without external dependencies.

@sibson sibson merged commit a92eafc into sibson:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sibson sibson sibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ponty @sibson