Repository navigation
Conversation
…tgg#13175) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 6975efd)
After pingdotgg#13175 the badge's text was 12px/400, but only on an inner display:contents span: the control around it (an InlineButton in the sidebar) kept its inherited 16px size, 24px line box and font-medium, so the badge sat a pixel below the timestamp baseline and its hover underline was drawn for the larger link. The badge now puts its meta typography (font-normal text-xs tabular-nums, plus the state tone) on the control through useRender's merged props and drops the contents span. The badge owns its type, as in pingdotgg#13208, so no call site restyles the control, and every sidebar and the composer toolbar share the fix. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Moving the tone onto the badge's control let a control's own hover colour win: the composer's ComposerControl (hover:text-foreground/80) turned a merged badge grey, icon included. The tone goes back on an inner contents span around the icon and number, as upstream had it, so no control hover or focus colour reaches them. The meta type stays on the control, which is what keeps the badge on the timestamp baseline, and the control keeps the tone too, so an InlineButton's hover underline takes it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The it.each table held JSX elements in an array literal, which tripped two react(jsx-key) warnings. Each row now holds a factory that renders its control. No behaviour change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request badge in the sidebar rendered at 16px/500, larger and bolder than the 14px thread title. That regression came from pingdotgg#13034; upstream t3code fixed it in pingdotgg#13175, which is not yet in this fork.
6975efd3dd(fix(web): the pull request badge reads at the meta size again pingdotgg/t3code#13175, "the pull request badge reads at the meta size again") with-x.InlineButtonwhile its inner text was 12px, which put the badge 1px below the timestamp baseline and gave the hover underline the wrong weight.hover:text-foreground/80. Without that, the composer badge turned grey on hover.Verified in a real render on synthetic data: the badge baseline is within 0.00px of the timestamp in sidebar rows and of the branch name in the composer, and the state colour holds at rest, on hover and on keyboard focus in the sidebar and the composer, light and dark.
ThreadStatusIndicators.test.tsxcovers the type and the colour surviving hover for bothInlineButtonandComposerControl, and fails without the fix.Known residue, not from this PR:
lint:restyle-ceilingalready fails on main (632 findings against a ceiling of 628); this PR adds none.🤖 Generated with Claude Code