Skip to content

Repository navigation

fix(app): keep session tab preview from intercepting clicks #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuv1337 merged 2 commits into from
Oct 6, 2026
Merged

fix(app): keep session tab preview from intercepting clicks #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9877e1d
fix(app): keep session tab preview from intercepting clicks
shuv1337 Oct 6, 2026
5b2723e
test(app): hold the tab preview open in the folder-switch regression
shuv1337 Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/app/e2e/regression/tabs.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,10 +484,6 @@ test("five loaded workspace tabs stay rendered and reactive through repeated swi
})

test("each session tab shows its own file tab after a switch to a session in another folder", async ({ page }) => {
test.fixme(
true,
"FolderSwitch project label covers the Open file button: https://github.com/shuv1337/shuvcode/issues/438",
)
await page.setViewportSize({ width: 1440, height: 900 })
const directory = "C:/OpenCode/FolderSwitch"
const alpha = { id: "ses_folderswitch_alpha", title: "Folder switch alpha" }
Expand Down Expand Up @@ -520,6 +516,8 @@ test("each session tab shows its own file tab after a switch to a session in ano

await open("greet.ts")
await visit(other)
// The pointer rests on the switched tab, so its hover preview opens over Open file and must not take the click.
await expect(page.locator('[data-component="session-tab-popover"]')).toBeVisible()
await open("notes.txt")
await visit(beta)
await open("guide.md")
Expand Down
4 changes: 3 additions & 1 deletion packages/app/src/shell/titlebar/tab-popover.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
color: var(--v2-text-text-base);
font-variant-numeric: tabular-nums;
user-select: none;
pointer-events: none;
/* Kobalte's layer stack writes inline pointer-events: auto on every mounted
layer; the preview must never intercept clicks on what it covers. */
pointer-events: none !important;

transform-origin: var(--kb-hovercard-content-transform-origin);
/* Entrance: instant (trying no animation — may revert to 120ms ease-out). */
Expand Down
Loading