Repository navigation
fix(cli): bound run setup RPCs and report startup progress - #434
Merged
Merged
Conversation
Add per-request setup deadlines while leaving execution and its event stream uncapped. Report ambiguous prompt admission with its session and request IDs, and keep piped stdin intact until EOF. Fixes #412
Owner
Author
|
🔍 Automated Cursor review is underway. Please hold off on merging until the review comment lands here (usually 10–20 minutes). |
Owner
Author
|
Review complete: no findings. Checked that setup deadlines stay off execution RPCs and the event stream, timers are cleared when a setup call finishes, an admission timeout does not retry or open another session, JSON stays on stdout, and the subprocess tests use an isolated temp server with scaled deadlines. |
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shuvcode runcould wait silently on uncapped setup RPCs before producing output. Startup and stdin progress now go to stderr. Location and session setup RPCs have individual 30-second deadlines; prompt admission has a separate 120-second deadline to accommodate plugin activation. Execution and its event stream remain uncapped.An admission timeout reports the known session and request IDs as ambiguous delivery and exits without retrying admission or creating a replacement session. Piped input still waits for EOF and retains late input.
Validation covered isolated candidate CLIs with explicit loopback fake-server endpoints and isolated HOME plus all four XDG directories: setup and response-body stalls, ambiguous admission without duplicates, cleanup blocked on another RPC, nonempty healthy output, and delayed piped input. The pipeline also passed unscaled 30-second setup and 120-second admission probes, a 150-second execution stream, and stdin held open for 40 seconds. The fixture-driven CI cases use proportionally shorter deadlines. Root lint and type checks passed.
Fixes #412