Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start work on uuid support #411

Draft
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

iamwacko
Copy link
Collaborator

@iamwacko iamwacko commented Jan 20, 2023

UUID was implemented as a string, which meant it would not work with the UUID type in databases. #270

@iamwacko iamwacko marked this pull request as draft January 20, 2023 15:43
@iamwacko
Copy link
Collaborator Author

If anyone wants this merged they have to figure out how to make pretty printing the OwnedSerializable in the test_compile_and_generate test in the core crate not give an error along the lines of key must be a string.

@iamwacko iamwacko added the help wanted Extra attention is needed label Jan 24, 2023
@ratskates
Copy link

Any chance of getting this merged in ? It's a read blocker for me.

@JRileyH
Copy link

JRileyH commented Apr 17, 2023

What's the realistic timeline of getting this merged? I cannot use synth until UUIDs are supported in postgres.

Also thanks for taking his on @iamwacko :) Looks like more than a few people will be really happy to see this fixed.

@iamwacko
Copy link
Collaborator Author

I don't really have a schedule. It should be working, and rust-gdb even shows UUID's in memory. The only blocker is the key must be a string error, which I have spent hours trying to fix. If anyone could figure out how to deal with it I could put out a new release that day.

@njohnson-ml
Copy link

@iamwacko do you get any more info on the failure when you set RUST_BACKTRACE=1?

@murugesanp92
Copy link

@iamwacko any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants