cargo shuttle init does not handle directory argument properly #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #665 skip over prompting for directory name if directory name is specified in init command not solved issue of file path being created properly as don't have time right now but will look into this later
Issue #665 skip over prompting for directory name if directory name is specified in init command not solved issue of file path being created properly as don't have time right now but will look into this later
…ttle into shuttle_init_directory_bug_665
…ttle into shuttle_init_directory_bug_665
…ttle into shuttle_init_directory_bug_665
…ttle into shuttle_init_directory_bug_665
…ttle into shuttle_init_directory_bug_665
…ttle into shuttle_init_directory_bug_665
…ttle into shuttle_init_directory_bug_665
|
Hey @h-dav, thanks for this 🙏 There is a note in your comment about looking into the file path being created correctly, are you still doing that or is this ready for review? No rush of course, just curious! |
|
Hi @oddgrd, I’m happy to do the file path being created correctly issue but currently don’t have time. The pull request is ready to be reviewed but it only fixes one of the issues detailed on the linked issue. However, I can create another pull request for the file path issue once it’s ready. |
oddgrd
reviewed
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #665
Description of change
Skip over prompting for directory name if directory name is specified in init command
Note: Not solved issue of file path being created properly as don't have time right now but will look into this later
closes issue #665