-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: refactor and improve speed and caching. add rustls flags to aws-rds #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaro00
force-pushed
the
ci/refactor-and-cost
branch
5 times, most recently
from
August 21, 2023 16:07
a2345db
to
04cbaf4
Compare
jonaro00
force-pushed
the
ci/refactor-and-cost
branch
12 times, most recently
from
August 21, 2023 23:14
887f961
to
a631562
Compare
jonaro00
force-pushed
the
ci/refactor-and-cost
branch
from
August 21, 2023 23:29
a631562
to
748acaa
Compare
jonaro00
changed the title
Ci/refactor and cost
ci: refactor and improve speed and caching. add rustls flags to aws-rds
Aug 22, 2023
iulianbarbu
reviewed
Aug 22, 2023
iulianbarbu
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
oddgrd
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just left some suggestions for clean up, nothing major.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Replaces #1017.
Lots of testing done: https://app.circleci.com/pipelines/github/shuttle-hq/shuttle?branch=pull%2F1167