Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor and improve speed and caching. add rustls flags to aws-rds #1167

Merged
merged 8 commits into from
Aug 22, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Aug 21, 2023

Description of change

Replaces #1017.

  • CI improvements. Optimized caches and core count to both speed up and reduce costs.
  • added rustls feature flags to aws-rds
  • cargo update

Lots of testing done: https://app.circleci.com/pipelines/github/shuttle-hq/shuttle?branch=pull%2F1167

@jonaro00 jonaro00 force-pushed the ci/refactor-and-cost branch 5 times, most recently from a2345db to 04cbaf4 Compare August 21, 2023 16:07
@jonaro00 jonaro00 force-pushed the ci/refactor-and-cost branch 12 times, most recently from 887f961 to a631562 Compare August 21, 2023 23:14
@jonaro00 jonaro00 force-pushed the ci/refactor-and-cost branch from a631562 to 748acaa Compare August 21, 2023 23:29
@jonaro00 jonaro00 marked this pull request as ready for review August 22, 2023 00:14
@jonaro00 jonaro00 changed the title Ci/refactor and cost ci: refactor and improve speed and caching. add rustls flags to aws-rds Aug 22, 2023
resources/aws-rds/src/lib.rs Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
Copy link
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just left some suggestions for clean up, nothing major.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
resources/aws-rds/README.md Outdated Show resolved Hide resolved
@jonaro00 jonaro00 merged commit de362f8 into shuttle-hq:main Aug 22, 2023
@jonaro00 jonaro00 deleted the ci/refactor-and-cost branch August 22, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants