Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interactive project initialisation #14

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

Procrat
Copy link
Contributor

@Procrat Procrat commented Nov 30, 2022

Counterpart of shuttle-hq/shuttle#498

@oddgrd
Copy link
Contributor

oddgrd commented Dec 5, 2022

Hey Procrat, good thinking on updating the docs! I am wondering though, if we remove the project new step from the examples but keep the init call as is (cargo shuttle init --axum) the project (the deployer container) won't have been created before the deploy step. Perhaps we should just keep the project new step?

Alternatively we could change to just init and tell the user to choose a unique name and the correct framework. For the quickstart page we should probably do that, but tell the user to choose the framework they want.

@Procrat
Copy link
Contributor Author

Procrat commented Dec 6, 2022

Like I implemented it (but let me know if it's not ideal), cargo shuttle init --axum will still start an interactive mode that'll ask whether the user wants to create an environment. It's only when both the framework and the project name are supplied that it won't prompt for anything. Should I change it everywhere to that perhaps?

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right! I only tested this with the name arg included (and I doubt the user will do that). I think it's perfect like this then, thanks!

@brokad brokad merged commit b9ee313 into shuttle-hq:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants