fix: remove thinking model variants and update model versions - #908
Conversation
Entire-Checkpoint: a00af1661e7a
Entire-Checkpoint: c365e3747c58
Entire-Checkpoint: 5c990eef381d
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
Summary of ChangesHello @shunkakinoki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the model configuration by deprecating and removing specific 'thinking' model variants for Claude. It updates various settings and templates to reflect these changes, ensuring consistency across the system and simplifying model references. The overall impact is a cleaner and more up-to-date model management setup. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Mesa DescriptionTL;DRRemove thinking model variants and update model versions for Claude models. What changed?
Validation
Description generated by Mesa. Update settings |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (8)
📝 WalkthroughSummary by CodeRabbit
WalkthroughConfiguration files updated to remove Claude thinking model variants and their aliases across multiple settings files. Model references changed from thinking versions to standard versions (e.g., claude-opus-4-6-thinking to claude-opus-4-6), and thinking model entries removed from model registries and proxy configurations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the removal of 'thinking' model variants and updates model versions across various configuration files. The changes are consistent with the summary provided, including the removal of claude-opus-thinking and claude-sonnet-thinking entries, updating templates to use non-thinking model variants, removing the redundant oauth-model-alias block, and updating Haiku and Sonnet model version strings. The changes are well-contained and directly implement the stated objectives, contributing to cleaner and more up-to-date configurations. The test plan indicates that the llm-update.sh script was run successfully, which is a good practice for validating such configuration changes.
There was a problem hiding this comment.
Pull request overview
This PR removes support for Claude thinking model variants from the configuration system and updates model version strings. The changes ensure that all configurations use standard Claude model variants instead of the deprecated -thinking variants.
Changes:
- Removed
claude-opus-thinkingandclaude-sonnet-thinkingentries from the central models.json configuration - Updated template files to use standard model placeholders (e.g.,
__CLAUDE_OPUS__instead of__CLAUDE_OPUS_THINKING__) - Updated model version strings in Claude settings from
claude-sonnet-4-6-1mtoclaude-sonnet-4-6
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| models.json | Removed thinking model variant entries for opus and sonnet |
| config/openclaw/openclaw.tpl.json | Removed thinking model configurations with reasoning flag set to true |
| config/openclaw/openclaw.template.json | Removed generated thinking model entries (claude-opus-4-6-thinking, claude-sonnet-4-6-thinking) |
| config/cliproxyapi/config.tpl.yaml | Removed oauth-model-alias block that was mapping thinking variants to standard variants |
| config/cliproxyapi/config.template.yaml | Removed generated oauth-model-alias configuration block |
| config/claude/settings.json | Updated HAIKU_MODEL and SONNET_MODEL version strings from claude-sonnet-4-6-1m to claude-sonnet-4-6 |
| config/ccs/agy.settings.tpl.json | Updated template placeholders from CLAUDE_OPUS_THINKING to CLAUDE_OPUS |
| config/ccs/agy.settings.template.json | Updated generated model references from claude-opus-4-6-thinking to claude-opus-4-6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Summary
claude-opus-thinkingandclaude-sonnet-thinkingentries frommodels.json__CLAUDE_OPUS__instead of__CLAUDE_OPUS_THINKING__)oauth-model-aliasblock from cliproxyapi configTest plan
bash scripts/llm-update.shto regenerate all configs successfully🤖 Generated with Claude Code
Summary by cubic
Remove the deprecated “thinking” model variants and switch all configs/templates to the non-thinking Claude models. Also update model version strings and drop an unused cliproxy alias to simplify configuration.
Written for commit 4b3615b. Summary will update on new commits.