Skip to content

feat: add WhatsApp to homebrew and fix llm-update script - #815

Merged
shunkakinoki merged 2 commits into
mainfrom
whats
Feb 15, 2026
Merged

feat: add WhatsApp to homebrew and fix llm-update script#815
shunkakinoki merged 2 commits into
mainfrom
whats

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Feb 15, 2026

Copy link
Copy Markdown
Owner

Changes Made

  • Added WhatsApp to the list of brews in homebrew.nix
  • Corrected shellcheck directive in llm-update.sh
  • Updated grep command for Claude model names to fix pattern matching

Technical Details

  • Modified nix-darwin/config/homebrew.nix to include WhatsApp
  • Fixed shellcheck directive in scripts/llm-update.sh
  • Updated spec/llm_update_spec.sh with corrected grep pattern for model names

Testing

  • All pre-commit hooks pass (Biome formatting, linting)
  • Shellcheck validation passes
  • Manual testing completed

🤖 Generated with opencode


Summary by cubic

Add WhatsApp to the nix-darwin Homebrew apps and fix the llm-update script/test so linting passes and Claude model names match correctly.

  • New Features

    • Add "whatsapp" to nix-darwin/config/homebrew.nix for automatic install.
  • Bug Fixes

    • Disable ShellCheck SC2016 for the JQ_PRETTY function in scripts/llm-update.sh.
    • Update grep in spec/llm_update_spec.sh to match Claude model names correctly.

Written for commit ee4103a. Summary will update on new commits.

Copilot AI review requested due to automatic review settings February 15, 2026 12:51
@mesa-dot-dev

mesa-dot-dev Bot commented Feb 15, 2026

Copy link
Copy Markdown

You do not have enough credits to review this pull request. Please purchase more credits to continue.

@coderabbitai

coderabbitai Bot commented Feb 15, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Added WhatsApp to application management configuration.
    • Added code quality suppression directive to build automation scripts.
  • Tests

    • Refined test assertion pattern for model name validation to improve accuracy.

Walkthrough

This PR adds the WhatsApp homebrew cask to the nix-darwin configuration, includes a shellcheck lint-suppression directive in a shell script, and updates a test assertion pattern to match Claude without quotes.

Changes

Cohort / File(s) Summary
Homebrew Configuration
nix-darwin/config/homebrew.nix
Added "whatsapp" cask to the homebrew casks list.
Shell Script & Tests
scripts/llm-update.sh, spec/llm_update_spec.sh
Added shellcheck SC2016 suppression directive in the script and updated test assertion to match Claude without quotes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A whisper of WhatsApp joins the brew,
Lint warnings fade, tests ring true,
Three simple changes, all in place,
Making the config a better space! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch whats

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @shunkakinoki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the system configuration by adding WhatsApp to the Homebrew managed applications. It also addresses two issues within the LLM update script: a shellcheck warning is suppressed for a specific jq function, and the test suite's grep pattern for Claude model names is corrected to ensure accurate validation.

Highlights

  • Homebrew Configuration: Integrated WhatsApp into the homebrew.nix configuration, expanding the set of managed applications.
  • LLM Update Script Fix: Corrected a shellcheck directive in llm-update.sh to properly handle a specific jq function.
  • Test Specification Update: Refined the grep command within spec/llm_update_spec.sh to accurately match Claude model names.
Changelog
  • nix-darwin/config/homebrew.nix
    • Added "whatsapp" to the list of homebrew packages.
  • scripts/llm-update.sh
    • Inserted a shellcheck disable=SC2016 directive above the JQ_PRETTY definition.
  • spec/llm_update_spec.sh
    • Modified the grep command from grep '"Claude"' to grep 'Claude' in the test for capitalizing Claude model names.
Activity
  • Pre-commit hooks (Biome formatting, linting) passed.
  • Shellcheck validation passed.
  • Manual testing was completed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@shunkakinoki
shunkakinoki merged commit 87c6672 into main Feb 15, 2026
31 of 32 checks passed
@shunkakinoki
shunkakinoki deleted the whats branch February 15, 2026 12:51
@mesa-dot-dev

mesa-dot-dev Bot commented Feb 15, 2026

Copy link
Copy Markdown

Mesa Description

TL;DR

Added WhatsApp to Homebrew via Nix-Darwin and fixed issues in the llm-update.sh script and its corresponding test.

What changed?

  • nix-darwin/config/homebrew.nix: The whatsapp cask has been added to the list of Homebrew applications.
  • scripts/llm-update.sh: A shellcheck directive was added to disable rule SC2016 for the JQ_PRETTY variable, which uses a jq function to derive display names from model IDs.
  • spec/llm_update_spec.sh: The grep command in a test was updated to search for the literal string 'Claude' by removing extraneous inner double quotes, fixing pattern matching for Claude model names.

Description generated by Mesa. Update settings

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request contains three distinct and well-scoped changes. First, it adds 'whatsapp' to the Homebrew cask list, correctly maintaining the alphabetical order of the list. Second, it introduces a shellcheck disable directive for SC2016 in scripts/llm-update.sh, which is an appropriate way to handle a false positive from the linter regarding jq syntax. Finally, it refactors a grep command in spec/llm_update_spec.sh to simplify the quoting, which improves readability. All changes are sound and I see no issues.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes three minor improvements to the dotfiles repository: adds WhatsApp to the Homebrew cask list, fixes a shellcheck warning in the llm-update script, and corrects a grep pattern in the corresponding test file.

Changes:

  • Added WhatsApp to the alphabetically-sorted list of Homebrew casks
  • Added shellcheck disable directive for SC2016 in llm-update.sh to suppress warnings about single-quoted strings containing dollar signs
  • Corrected grep pattern in test to match codebase conventions by removing unnecessary embedded quotes

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
nix-darwin/config/homebrew.nix Added "whatsapp" to the casks list in alphabetical order
scripts/llm-update.sh Added shellcheck disable directive for SC2016 before the JQ_PRETTY variable definition
spec/llm_update_spec.sh Fixed grep pattern from grep '"Claude"' to grep 'Claude' to match testing conventions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants