Skip to content

fix: run neovim-upgrade in dev shell on CI and add daily Renovate workflow #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 7 commits into from
Feb 9, 2026
Merged

fix: run neovim-upgrade in dev shell on CI and add daily Renovate workflow #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e878e96
fix: run neovim-upgrade in dev shell on CI and add daily Renovate wor…
shunkakinoki Feb 9, 2026
9ac4643
fix: add pull_request trigger and condition for creating pull request
shunkakinoki Feb 9, 2026
fa470e3
fix: update cron schedule for upgrade workflow to run at 3 AM
shunkakinoki Feb 9, 2026
bcb6fb8
fix: simplify configText assignment in ghostty default.nix
shunkakinoki Feb 9, 2026
24a8d34
fix: break infinite recursion in neovim-upgrade-dev
shunkakinoki Feb 9, 2026
cbeb9aa
Revert "fix: break infinite recursion in neovim-upgrade-dev"
shunkakinoki Feb 9, 2026
5666f8f
fix: add upgrade-dev target and use it in CI workflow
shunkakinoki Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/renovate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Renovate
on:
schedule:
- cron: '0 3 * * *'
workflow_dispatch:
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.head_ref || github.sha }}
cancel-in-progress: true
Comment on lines +6 to +8

Copilot AI Feb 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concurrency group includes ${{ github.sha }}, which changes on every scheduled run; this prevents cancel-in-progress: true from cancelling a previous still-running scheduled Renovate job (each run will end up in a different group). For schedule-based workflows, consider using a stable key like ${{ github.workflow }}-${{ github.event_name }} (optionally plus ${{ github.ref }}) so overlapping runs get cancelled as intended.

Copilot uses AI. Check for mistakes.
jobs:
renovate:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@v6
- name: Renovate
uses: renovatebot/github-action@v46.0.2
with:
configurationFile: renovate.json
token: ${{ secrets.PAT_TOKEN }}
renovate-check:
if: always()
needs:
- renovate
runs-on: ubuntu-latest
timeout-minutes: 3
steps:
- name: Alls Green
uses: re-actors/alls-green@release/v1
with:
jobs: ${{ toJSON(needs) }}
6 changes: 4 additions & 2 deletions .github/workflows/upgrade.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: Upgrade
on:
pull_request:
schedule:
- cron: '0 2 * * *'
- cron: '0 3 * * *'
workflow_dispatch:
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.head_ref || github.sha }}
Expand All @@ -21,11 +22,12 @@ jobs:
with:
github_access_token: ${{ secrets.GITHUB_TOKEN }}
- name: Run Upgrade
run: make upgrade
run: make upgrade-dev
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SKIP_HOME_MANAGER_SWITCH: "true"
- name: Create Pull Request
if: github.action != 'pull_request'

@coderabbitai coderabbitai Bot Feb 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Bug: github.action should be github.event_name.

github.action is the unique identifier of the step action (or the action's repo slug), not the event trigger name. This condition will almost certainly always evaluate to true, so PR creation will not be skipped on pull_request events as intended.

Proposed fix 
-        if: github.action != 'pull_request'
+        if: github.event_name != 'pull_request'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if: github.action != 'pull_request'
if: github.event_name != 'pull_request'
🤖 Prompt for AI Agents 
In @.github/workflows/upgrade.yml at line 30, The workflow conditional is using
the wrong context key: replace the condition "if: github.action !=
'pull_request'" with a check against the event name (e.g., use github.event_name
!= 'pull_request') so the step actually skips on pull_request events; update the
conditional expression where it appears in the upgrade.yml workflow to reference
github.event_name instead of github.action.

id: cpr
uses: peter-evans/create-pull-request@v8
with:
Expand Down
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,11 @@ update-local-binaries: ## Update and rebuild local binaries from .local-binaries
.PHONY: upgrade
upgrade: nix-upgrade overlays-upgrade neovim-upgrade ## Upgrade Nix flake, overlays, Neovim plugins

.PHONY: upgrade-dev
upgrade-dev: ## Upgrade inside the Nix dev shell (mirrors CI).
@echo "🔄 Running upgrade inside the Nix dev shell..."
@DEVENV_ROOT=$(CURDIR) $(NIX_ALLOW_UNFREE) $(NIX_EXEC) develop $(NIX_FLAGS) .# --command $(MAKE) upgrade

.PHONY: dev
dev: nix-develop ## Enter the Nix dev shell (alias for nix-develop).

Expand Down
5 changes: 1 addition & 4 deletions config/ghostty/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
let
fishPath = "${pkgs.fish}/bin/fish";
staticConfig = builtins.readFile ./config;
configText = builtins.replaceStrings
[ "__FISH_PATH__" ]
[ fishPath ]
staticConfig;
configText = builtins.replaceStrings [ "__FISH_PATH__" ] [ fishPath ] staticConfig;
in
{
xdg.configFile."ghostty/config" = {
Expand Down
Loading