Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions named-hosts/matic/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ inputs.nixpkgs.lib.nixosSystem {
# Power management
services.power-profiles-daemon.enable = true;

# Desktop environment (GNOME)
services.xserver.enable = true;
services.xserver.displayManager.gdm.enable = true;
services.xserver.desktopManager.gnome.enable = true;
Comment on lines +80 to +82

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Enabling services.xserver.desktopManager.gnome.enable is sufficient here. This option automatically enables both the X server (services.xserver.enable) and the GDM display manager (services.xserver.displayManager.gdm.enable) by default. Removing the explicit declarations for them will make the configuration more concise and rely on the sensible defaults from the GNOME module.

        services.xserver.desktopManager.gnome.enable = true;

Comment on lines +79 to +82

Copilot AI Feb 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says X11 is enabled with GDM, but by default GDM prefers Wayland sessions. If the intent is to force an X11-based GNOME session, set services.xserver.displayManager.gdm.wayland = false; and/or configure services.xserver.displayManager.defaultSession accordingly; otherwise, please update the PR description to avoid implying X11-only.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

GNOME typically requires additional services for full functionality. Consider adding:

# Enable GNOME keyring for credential storage
services.gnome.gnome-keyring.enable = true;

# Or for non-GNOME-specific keyring:
security.pam.services.gdm.enableGnomeKeyring = true;

Without keyring services, applications requiring credential storage (browsers, email clients, SSH key management) may not function properly or will repeatedly prompt for passwords.

Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#716
File: named-hosts/matic/default.nix#L82
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
GNOME typically requires additional services for full functionality. Consider adding:

```nix
# Enable GNOME keyring for credential storage
services.gnome.gnome-keyring.enable = true;

# Or for non-GNOME-specific keyring:
security.pam.services.gdm.enableGnomeKeyring = true;

Without keyring services, applications requiring credential storage (browsers, email clients, SSH key management) may not function properly or will repeatedly prompt for passwords.


</details>


# WiFi MT7925e fix (disable ASPM)
boot.extraModprobeConfig = ''
options mt7925e disable_aspm=1
Expand Down
Loading