feat: add node program configuration - #684
Conversation
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
Summary of ChangesHello @shunkakinoki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Node.js program configuration into the existing home-manager setup. It establishes a dedicated module for Node.js, ensuring that the necessary packages are included in the user's environment, thereby streamlining the management of Node.js development tools. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Mesa DescriptionTL;DRAdded Node.js program configuration to home-manager. What changed?
Description generated by Mesa. Update settings |
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughAdds Node.js support to home-manager by introducing a new node module. The changes consist of exposing a node binding in the programs directory and defining a configuration module that installs Node.js into the user's home-manager environment. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully introduces a new Home Manager module for Node.js configuration. The new module home-manager/programs/node/default.nix correctly defines the node package to be installed. However, the newly imported node module in home-manager/programs/default.nix is not included in the final list of enabled programs, which means the configuration will not be applied.
| lazygit = import ./lazygit; | ||
| lsd = import ./lsd; | ||
| neovim = import ./neovim; | ||
| node = import ./node; |
There was a problem hiding this comment.
The node module is correctly imported here. However, for the configuration to be applied, you also need to add node to the list of enabled programs in the in block further down in this file (around lines 37-65). Without this, the Node.js configuration will not be active.
There was a problem hiding this comment.
Pull request overview
This PR adds a new Node.js program configuration module to home-manager, providing a simple way to install Node.js directly as a system package.
Changes:
- Created a new
nodeprogram module that adds Node.js to home.packages - Added the module import to the programs/default.nix file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| home-manager/programs/node/default.nix | New module that adds Node.js package to home.packages |
| home-manager/programs/default.nix | Import statement for the new node module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { pkgs, ... }: | ||
| { | ||
| home.packages = with pkgs; [ | ||
| node |
There was a problem hiding this comment.
The package name "node" does not exist in nixpkgs. Node.js packages are named "nodejs_22", "nodejs_20", "nodejs_18", etc., or you can use "nodejs" for the default version. Consider using "nodejs" or a specific version like "nodejs_22" to match the versioning in the fnm module which uses versions 22 and 20.
| node | |
| nodejs |
| lazygit = import ./lazygit; | ||
| lsd = import ./lsd; | ||
| neovim = import ./neovim; | ||
| node = import ./node; |
There was a problem hiding this comment.
The node module is imported but not added to the list of modules returned by this file. All imported modules need to be included in the returned list (lines 37-65). The node module should be added to maintain consistency with other program modules.
| { pkgs, ... }: | ||
| { | ||
| home.packages = with pkgs; [ | ||
| node | ||
| ]; | ||
| } |
There was a problem hiding this comment.
This module may conflict with or be redundant to the existing fnm (Fast Node Manager) module at home-manager/programs/fnm/default.nix, which already manages Node.js installation through version management. Consider whether this module is needed, or if it should be used as an alternative to fnm for users who prefer a direct Node.js installation. If both modules are meant to coexist, add documentation explaining when to use each approach.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| lazygit = import ./lazygit; | ||
| lsd = import ./lsd; | ||
| neovim = import ./neovim; | ||
| node = import ./node; |
There was a problem hiding this comment.
Node module imported but not included in returned list
High Severity
The node module is imported on line 26 but is not added to the returned list of modules at the end of the file. All other imported modules (like python, rust, go) are included in the returned list, but node is missing. This means the node configuration will never be loaded or applied, making the feature completely non-functional.
| { pkgs, ... }: | ||
| { | ||
| home.packages = with pkgs; [ | ||
| node |
There was a problem hiding this comment.
Wrong package name: node should be nodejs
High Severity
The package is specified as node but the correct nixpkgs package name for Node.js is nodejs. Using pkgs.node will fail to build because this package doesn't exist in nixpkgs. The package reference needs to be nodejs (or a versioned variant like nodejs_20).
| home.packages = with pkgs; [ | ||
| node | ||
| ]; | ||
| } |
There was a problem hiding this comment.
Redundant Node.js module duplicates fnm functionality
Low Severity
The new node module adds Node.js directly via home.packages, but the existing fnm module already provides comprehensive Node.js management. The fnm module pre-installs Node.js versions 22 and 20, sets up version switching, and creates symlinks. Having both modules enabled would result in redundant installations and potential confusion about which Node.js is being used.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
home-manager/programs/default.nix (1)
55-57: Node module imported but not exported.The
nodemodule is imported at line 26 but is missing from the exported array. This means Node.js will not be installed—the import is dead code.🐛 Proposed fix: Add `node` to the exported list (alphabetically between `neovim` and `python`)
neovim + node python
🤖 Fix all issues with AI agents
In `@home-manager/programs/node/default.nix`:
- Around line 3-5: Replace the incorrect package attribute name in the
home.packages list: change the reference to node to the correct nixpkgs
attribute nodejs so home.packages = with pkgs; [ nodejs ]; ensuring the Node.js
package resolves properly during evaluation.
| home.packages = with pkgs; [ | ||
| node | ||
| ]; |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's check the actual file content
cat -n home-manager/programs/node/default.nixRepository: shunkakinoki/dotfiles
Length of output: 170
🏁 Script executed:
# Verify nixpkgs packages - check if both 'node' and 'nodejs' exist
# and what they point to
rg -i "node" --type nix | head -20Repository: shunkakinoki/dotfiles
Length of output: 1698
🌐 Web query:
home-manager nodejs programs module
💡 Result:
Home Manager does not have a programs.nodejs module; for Node.js you typically just install a Node package via home.packages, and (optionally) manage npm configuration via programs.npm.*. Home Manager program modules usually live under programs.<name>, but many tools (like Node.js) are just installed as packages instead. [4]
Example (home.nix)
{ pkgs, ... }:
{
home.packages = [
pkgs.nodejs_24 # or pkgs.nodejs, pkgs.nodejs_22, etc.
];
programs.npm = {
enable = true; # manage ~/.npmrc [3]
package = pkgs.nodejs_24; # which nodejs provides npm [1]
settings = {
prefix = "${HOME}/.npm"; # default, example override [2]
};
};
}If your goal is just “install Node”, home.packages = [ pkgs.nodejs_<version> ]; is the key piece. [4]
🌐 Web query:
nixpkgs nodejs node package name
💡 Result:
In nixpkgs, Node-related packages typically show up under these attribute names:
-
Node.js runtime
nodejs= alias for the latest LTS Node.js in nixpkgs (manually updated in nixpkgs). [2]- Versioned runtimes are named like
nodejs_20,nodejs_24, etc. (andnodejs_latesttracks the latest “current” release; e.g., release notes mentionnodejs_latestmoving to 24.x andnodejs_24existing). [1][3] - Discover exact names on your channel with:
nix search nixpkgs nodejs. [2]
-
npm “end-user” CLI tools packaged in nixpkgs
- These are in the generated set
nodePackages(and a “current” variantnodePackages_latest). [3] - Naming:
- Unscoped:
nodePackages.<name>(example:nodePackages.typescript) - Scoped npm names use quotes:
nodePackages."@scope/name"(example from release notes:nodePackages."@commitlint/config-conventional"). [1]
- Unscoped:
- These are in the generated set
If you tell me the exact npm package name (e.g. eslint, @angular/cli, etc.), I can tell you the most likely nixpkgs attribute and a nix search command to confirm it.
Incorrect package name: node should be nodejs.
In nixpkgs, the Node.js package is named nodejs, not node. Using node will cause a build failure because this attribute does not exist in nixpkgs.
Proposed fix
home.packages = with pkgs; [
- node
+ nodejs
];📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| home.packages = with pkgs; [ | |
| node | |
| ]; | |
| home.packages = with pkgs; [ | |
| nodejs | |
| ]; |
🤖 Prompt for AI Agents
In `@home-manager/programs/node/default.nix` around lines 3 - 5, Replace the
incorrect package attribute name in the home.packages list: change the reference
to node to the correct nixpkgs attribute nodejs so home.packages = with pkgs; [
nodejs ]; ensuring the Node.js package resolves properly during evaluation.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="home-manager/programs/default.nix">
<violation number="1" location="home-manager/programs/default.nix:26">
P2: `node` module is imported but never added to the returned module list, so its configuration is never applied.</violation>
</file>
<file name="home-manager/programs/node/default.nix">
<violation number="1" location="home-manager/programs/node/default.nix:4">
P0: Incorrect package name: `node` does not exist in nixpkgs. The correct package name for Node.js is `nodejs`. This will cause a build failure.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| { pkgs, ... }: | ||
| { | ||
| home.packages = with pkgs; [ | ||
| node |
There was a problem hiding this comment.
P0: Incorrect package name: node does not exist in nixpkgs. The correct package name for Node.js is nodejs. This will cause a build failure.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At home-manager/programs/node/default.nix, line 4:
<comment>Incorrect package name: `node` does not exist in nixpkgs. The correct package name for Node.js is `nodejs`. This will cause a build failure.</comment>
<file context>
@@ -0,0 +1,6 @@
+{ pkgs, ... }:
+{
+ home.packages = with pkgs; [
+ node
+ ];
+}
</file context>
| lazygit = import ./lazygit; | ||
| lsd = import ./lsd; | ||
| neovim = import ./neovim; | ||
| node = import ./node; |
There was a problem hiding this comment.
P2: node module is imported but never added to the returned module list, so its configuration is never applied.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At home-manager/programs/default.nix, line 26:
<comment>`node` module is imported but never added to the returned module list, so its configuration is never applied.</comment>
<file context>
@@ -23,6 +23,7 @@ let
lazygit = import ./lazygit;
lsd = import ./lsd;
neovim = import ./neovim;
+ node = import ./node;
python = import ./python;
rust = import ./rust;
</file context>
Changes
Technical Details
Testing
make buildGenerated with Claude Code by claude-opencode
Note
Low Risk
Low risk Home Manager configuration change that only adds a new
nodemodule to install Node.js. Main risk is misconfiguration (the module is imported but not included in the exported module list, so it may not take effect).Overview
Adds a new
home-manager/programs/nodemodule that installs thenodepackage viahome.packages.Updates
home-manager/programs/default.nixto import the newnodemodule (note: it is imported but not added to the returned module list).Written by Cursor Bugbot for commit 96e627d. Configure here.
Summary by cubic
Adds a Node.js program module to Home Manager so Node is installed via home.packages. The new module lives at home-manager/programs/node/default.nix and is imported in home-manager/programs/default.nix.
Written for commit 96e627d. Summary will update on new commits.