Skip to content

refactor: manage foundry via nix instead of manual installation #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Jan 27, 2026
Merged

refactor: manage foundry via nix instead of manual installation #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@
url = "github:cachix/devenv";
inputs.nixpkgs.follows = "nixpkgs";
};
foundry = {
url = "github:shazow/foundry.nix";
inputs.nixpkgs.follows = "nixpkgs";
};
mk-shell-bin = {
url = "github:rrbutani/nix-mk-shell-bin";
};
Expand Down
1 change: 1 addition & 0 deletions home-manager/packages/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ with pkgs;
eza
fastfetch
fd
foundry-bin
fswatch
fzf-make
gh
Expand Down
1 change: 0 additions & 1 deletion home-manager/programs/bash/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
export PATH="$PATH:$GOPATH/bin"
export PATH="$HOME/.bun/bin:$PATH"
export PATH="$HOME/.cargo/bin:$PATH"
export PATH="$HOME/.foundry/bin:$PATH"
export PATH="$HOME/.local/bin:$PATH"
export PATH="$HOME/.nix-profile/bin:$PATH"
export PATH="/nix/var/nix/profiles/default/bin:$PATH"
Expand Down
2 changes: 0 additions & 2 deletions home-manager/programs/fish/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
fish_add_path -p ~/.local/bin
fish_add_path -p ~/.bun/bin
fish_add_path -p ~/.cargo/bin
fish_add_path -p ~/.foundry/bin

@gemini-code-assist gemini-code-assist Bot Jan 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line is also removed on line 59, which suggests there is duplicated code for setting up the PATH in this file. While this PR correctly removes the manual foundry path from both locations, consider refactoring to eliminate this code duplication for better maintainability. For example, you could define the paths in a let block and reuse them.

fish_add_path -p ~/.nix-profile/bin
fish_add_path -p ~/go/bin
fish_add_path -p /nix/var/nix/profiles/default/bin
Expand All @@ -56,7 +55,6 @@
fish_add_path -p ~/.local/bin
fish_add_path -p ~/.bun/bin
fish_add_path -p ~/.cargo/bin
fish_add_path -p ~/.foundry/bin
fish_add_path -p ~/.nix-profile/bin
fish_add_path -p ~/go/bin
fish_add_path -p /nix/var/nix/profiles/default/bin
Expand Down
1 change: 0 additions & 1 deletion home-manager/programs/zsh/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
export PATH="$PATH:$GOPATH/bin"
export PATH="$HOME/.bun/bin:$PATH"
export PATH="$HOME/.cargo/bin:$PATH"
export PATH="$HOME/.foundry/bin:$PATH"
export PATH="$HOME/.local/bin:$PATH"
export PATH="$HOME/.nix-profile/bin:$PATH"
export PATH="/nix/var/nix/profiles/default/bin:$PATH"
Expand Down
1 change: 1 addition & 0 deletions overlays/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
[
inputs.nur.overlays.default
inputs.neovim-nightly-overlay.overlays.default
inputs.foundry.overlay
(final: prev: {
# Ensure neovim-unwrapped exposes a lua attribute for wrapper consumers (e.g., home-manager)
neovim-unwrapped =
Expand Down
Loading