Skip to content

feat(shell): add OpenSSL env vars for cargo builds on Linux #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Jan 20, 2026
Merged

feat(shell): add OpenSSL env vars for cargo builds on Linux #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions home-manager/programs/bash/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@
# Set XDG_RUNTIME_DIR on Linux for consistent socket paths (e.g., zellij)
if [ "$(uname)" = "Linux" ]; then
export XDG_RUNTIME_DIR="/run/user/$(id -u)"

# OpenSSL for cargo builds (rust crates like openssl-sys)
export PKG_CONFIG_PATH="${pkgs.openssl.dev}/lib/pkgconfig''${PKG_CONFIG_PATH:+:$PKG_CONFIG_PATH}"
export OPENSSL_DIR="${pkgs.openssl.dev}"
export OPENSSL_LIB_DIR="${pkgs.openssl.out}/lib"
export OPENSSL_INCLUDE_DIR="${pkgs.openssl.dev}/include"
Comment on lines +38 to +43

@coderabbitai coderabbitai Bot Jan 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鈿狅笍 Potential issue | 馃煛 Minor

馃З Analysis chain

馃弫 Script executed:

# First, let's examine the file to see the full context
head -n 50 home-manager/programs/bash/default.nix

Repository: shunkakinoki/dotfiles

Length of output: 1563

馃弫 Script executed:

# Also check if the file exists and its size
wc -l home-manager/programs/bash/default.nix

Repository: shunkakinoki/dotfiles

Length of output: 106

馃弫 Script executed:

# Let's examine the exact lines mentioned (38-43) with more context
sed -n '30,50p' home-manager/programs/bash/default.nix

Repository: shunkakinoki/dotfiles

Length of output: 858

馃弫 Script executed:

# Check the module structure - look at the beginning of the file
head -n 10 home-manager/programs/bash/default.nix

Repository: shunkakinoki/dotfiles

Length of output: 245

馃弫 Script executed:

# Check the exact length of line 40
sed -n '40p' home-manager/programs/bash/default.nix | wc -c

Repository: shunkakinoki/dotfiles

Length of output: 68

馃弫 Script executed:

# Check if openssl is declared as a dependency in this file
grep -n "openssl" home-manager/programs/bash/default.nix

Repository: shunkakinoki/dotfiles

Length of output: 432

馃弫 Script executed:

# Check if there are home.packages or similar dependencies declared
grep -n "home\." home-manager/programs/bash/default.nix | head -20

Repository: shunkakinoki/dotfiles

Length of output: 47

馃弫 Script executed:

# Let's look at the entire file to see if there are any package dependencies
cat home-manager/programs/bash/default.nix

Repository: shunkakinoki/dotfiles

Length of output: 2302

馃弫 Script executed:

# Check if there's a flake.nix that defines nixpkgs inputs
if [ -f "flake.nix" ]; then
  head -30 flake.nix | grep -A5 "nixpkgs"
fi

Repository: shunkakinoki/dotfiles

Length of output: 756

Line 40 exceeds the 100-character limit鈥攔efactor the PKG_CONFIG_PATH export.

The OpenSSL environment variable setup is technically sound: Nix string interpolation is correct, bash variable escaping with ''$ is proper, and the .dev/.out package split follows Nix conventions. The comment adequately documents the purpose. However, line 40 is 108 characters, violating the guideline of keeping lines under 100 characters in Nix files. Split this line for compliance with the style requirements.

馃 Prompt for AI Agents 
In `@home-manager/programs/bash/default.nix` around lines 38 - 43, The
PKG_CONFIG_PATH export line is over 100 chars; split it into multiple
concatenated strings to keep lines under the limit while preserving the same
value. Update the export statement that sets PKG_CONFIG_PATH (the line
referencing pkgs.openssl.dev and ${PKG_CONFIG_PATH:+:$PKG_CONFIG_PATH}) by
breaking the string interpolation into two or more quoted pieces (e.g., separate
the "${pkgs.openssl.dev}/lib/pkgconfig" segment from the
"${PKG_CONFIG_PATH:+:$PKG_CONFIG_PATH}" segment) so the resulting export
PKG_CONFIG_PATH assignment still produces the same final string but each source
line stays <=100 chars.

Comment on lines +39 to +43

Copilot AI Jan 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zsh configuration (home-manager/programs/zsh/default.nix) also has the same Linux-specific XDG_RUNTIME_DIR setup pattern but is missing the OpenSSL environment variables that are being added to bash and fish. For consistency, zsh should also receive the same OpenSSL environment variable configuration since it's an active shell in this repository.

Copilot uses AI. Check for mistakes.
fi

# Go configuration
Expand Down
6 changes: 6 additions & 0 deletions home-manager/programs/fish/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@
# Set XDG_RUNTIME_DIR on Linux for consistent socket paths (e.g., zellij)
if test (uname) = "Linux"
set -gx XDG_RUNTIME_DIR /run/user/(id -u)

# OpenSSL for cargo builds (rust crates like openssl-sys)
set -gx PKG_CONFIG_PATH "${pkgs.openssl.dev}/lib/pkgconfig" $PKG_CONFIG_PATH
set -gx OPENSSL_DIR "${pkgs.openssl.dev}"
set -gx OPENSSL_LIB_DIR "${pkgs.openssl.out}/lib"
set -gx OPENSSL_INCLUDE_DIR "${pkgs.openssl.dev}/include"
end

# Go configuration
Expand Down
Loading