fix(clawdbot): enable noSandbox for browser on Linux - #560
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbitRelease Notes
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThe change adds a Changes
Possibly related PRs
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @shunkakinoki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a browser startup failure on Linux for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Mesa DescriptionTL;DREnable What changed?File summaries are not available. The change involves adding Description generated by Mesa. Update settings |
The Chromium SUID sandbox requires the sandbox binary to be owned by root with mode 4755, which isn't the case in Nix. Enable noSandbox to allow headless browsing without the SUID sandbox.
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of 8dab6c6...86b067f
Analysis
-
Security Downgrade Without Opt-In: Chromium's sandbox is unconditionally disabled on Linux, removing a critical security layer without making this configurable. A compromised browser now has full access to clawdbot's user account, credentials, and secrets.
-
Platform-Specific Security Divergence: The change creates an undocumented security divergence between Linux and other platforms, embedding a significant security decision directly in the shared module rather than exposing it as a configurable option.
-
Global Application vs. Targeted Fix: The security weakening applies to all Linux deployments regardless of whether they could support proper SUID sandbox configuration, when a more targeted approach (runtime detection or host-specific configuration) would maintain security where possible.
-
Missing Alternative Protections: No documentation or implementation of compensating security controls (like bubblewrap or systemd confinement) is provided to mitigate the increased risk from disabling the browser sandbox.
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
0 files reviewed | 1 comments | Edit Agent Settings • Read Docs
| } | ||
| // lib.optionalAttrs pkgs.stdenv.isLinux { | ||
| executablePath = "${pkgs.chromium}/bin/chromium"; | ||
| noSandbox = true; # SUID sandbox requires root-owned binary with mode 4755 |
There was a problem hiding this comment.
Unconditionally disabling the Chromium sandbox on all Linux systems weakens browser isolation even on hosts where the SUID sandbox could be properly configured. Consider making this configurable via a module option like clawdbot.browser.noSandbox (defaulting to false) so that:
- The security trade-off is explicit in host configurations
- Only hosts that truly need it opt into the weaker security posture
- Future Nix updates that fix the SUID sandbox permissions can benefit automatically
Alternatively, implement runtime detection to check if ${pkgs.chromium}/libexec/chrome-sandbox has proper permissions before disabling the sandbox, so only broken environments bypass it.
Agent: 🏛 Architecture •
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#560
File: home-manager/modules/clawdbot/default.nix#L75
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
Unconditionally disabling the Chromium sandbox on all Linux systems weakens browser isolation even on hosts where the SUID sandbox could be properly configured. Consider making this configurable via a module option like `clawdbot.browser.noSandbox` (defaulting to `false`) so that:
1. The security trade-off is explicit in host configurations
2. Only hosts that truly need it opt into the weaker security posture
3. Future Nix updates that fix the SUID sandbox permissions can benefit automatically
Alternatively, implement runtime detection to check if `${pkgs.chromium}/libexec/chrome-sandbox` has proper permissions before disabling the sandbox, so only broken environments bypass it.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the noSandbox option for Chromium on Linux to address browser startup issues. The change itself is correct for the stated purpose. However, I've noticed a potential structural issue in how the Linux-specific browser options are being configured. The executablePath and the new noSandbox option are being merged at the top level of configOverrides, rather than within the browser attribute set. This is likely incorrect and could prevent the settings from being applied properly. I've left a suggestion to refactor this to ensure the browser configuration is structured correctly.
| } | ||
| // lib.optionalAttrs pkgs.stdenv.isLinux { | ||
| executablePath = "${pkgs.chromium}/bin/chromium"; | ||
| noSandbox = true; # SUID sandbox requires root-owned binary with mode 4755 | ||
| }; | ||
| } |
There was a problem hiding this comment.
The current structure merges executablePath and noSandbox into configOverrides at the top level, alongside browser. It's more conventional and likely correct for these browser-specific settings to be nested within the browser attribute set. This refactoring moves the Linux-specific browser attributes into the browser block, improving the configuration's clarity and correctness.
} // lib.optionalAttrs pkgs.stdenv.isLinux {
executablePath = "${pkgs.chromium}/bin/chromium";
noSandbox = true; # SUID sandbox requires root-owned binary with mode 4755
};
}
There was a problem hiding this comment.
Pull request overview
This PR fixes Chromium browser startup failures on Linux by disabling the SUID sandbox requirement that cannot be satisfied with Nix-installed Chromium.
Changes:
- Added
noSandbox = trueto the browser configuration for Linux systems to work around SUID sandbox permissions issues
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| // lib.optionalAttrs pkgs.stdenv.isLinux { | ||
| executablePath = "${pkgs.chromium}/bin/chromium"; | ||
| noSandbox = true; # SUID sandbox requires root-owned binary with mode 4755 |
There was a problem hiding this comment.
Setting noSandbox = true on Linux disables Chromium’s main security sandbox, so a malicious or compromised website loaded by this headless browser could escalate directly to arbitrary code execution with the full privileges of the clawdbot process and its user account. Instead of disabling the sandbox entirely, ensure the Chromium SUID helper is installed/configured correctly or run this browser inside an additional isolation boundary (e.g., container, separate low-privilege user/namespace) so that Chromium’s own sandbox can remain enabled.
| noSandbox = true; # SUID sandbox requires root-owned binary with mode 4755 | |
| # Rely on Chromium's default sandboxing for security; ensure the | |
| # SUID sandbox helper is installed/configured correctly on the host | |
| # instead of disabling it with `noSandbox = true`. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Summary
Enable `noSandbox = true` for the Chromium browser on Linux to fix browser startup failures.
Problem
Chromium's SUID sandbox requires the sandbox binary to be owned by root with mode 4755:
```
The SUID sandbox helper binary was found, but is not configured correctly.
/nix/store/.../chromium-sandbox/bin/__chromium-suid-sandbox needs to be owned by root with mode 4755
```
This isn't the case with Nix-installed Chromium.
Solution
Add `noSandbox = true` to the browser config on Linux. This disables the SUID sandbox and allows headless browsing to work.
Trade-off
Running without the SUID sandbox is slightly less secure, but acceptable for a headless browser used for web searches.
Summary by cubic
Enable noSandbox=true for Chromium on Linux to bypass the SUID sandbox requirement in Nix and fix headless browser startup failures. Restores Clawdbot’s headless browsing on Linux, with the trade-off of disabling the SUID sandbox.
Written for commit 86b067f. Summary will update on new commits.