Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion config/claude/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,20 @@
"frontend-design@claude-plugins-official": true,
"pr-review-toolkit@claude-plugins-official": true,
"code-simplifier@claude-plugins-official": true,
"ralph-wiggum@claude-plugins-official": true,
"ralph-loop@claude-plugins-official": true,
"serena@claude-plugins-official": true,
"typescript-lsp@claude-plugins-official": true,
"plan-export@cc-marketplace": true,
"safety-net@cc-marketplace": true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

The naming convention safety-net@cc-marketplace in Claude's config differs from cc-safety-net in OpenCode's config (line 292). This inconsistency could indicate: 1) Different plugin systems with different naming patterns, or 2) A configuration error where the plugins don't actually reference the same functionality. Verify that this naming difference is intentional and both plugins serve their intended purpose.

Agent: 🏛 Architecture • Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#527
File: config/claude/settings.json#L15
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
The naming convention `safety-net@cc-marketplace` in Claude's config differs from `cc-safety-net` in OpenCode's config (line 292). This inconsistency could indicate: 1) Different plugin systems with different naming patterns, or 2) A configuration error where the plugins don't actually reference the same functionality. Verify that this naming difference is intentional and both plugins serve their intended purpose.

},
"extraKnownMarketplaces": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

Adding an external GitHub marketplace without version pinning or integrity verification creates a supply chain security risk. Consider: 1) Pinning to a specific commit hash or tag instead of the default branch, 2) Adding a verification mechanism to ensure plugin integrity, or 3) Documenting the security implications of using external marketplaces in your security policy.

Agent: 🏛 Architecture • Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#527
File: config/claude/settings.json#L17
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
Adding an external GitHub marketplace without version pinning or integrity verification creates a supply chain security risk. Consider: 1) Pinning to a specific commit hash or tag instead of the default branch, 2) Adding a verification mechanism to ensure plugin integrity, or 3) Documenting the security implications of using external marketplaces in your security policy.

"cc-marketplace": {
"source": {
"source": "github",

Copilot AI Jan 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "source" object contains a nested "source" key with value "github", which appears redundant. Verify if this nested structure is intentional or if the configuration should have a different structure, such as using "type" or "provider" for the outer key instead of "source".

Suggested change
"source": "github",
"type": "github",

Copilot uses AI. Check for mistakes.
"repo": "kenryu42/cc-marketplace"
}
Comment on lines +17 to +22

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The marketplace name acme-tools is generic and its connection to the source repository kenryu42/cc-marketplace isn't immediately obvious. This could be confusing for future developers maintaining this configuration.

To improve clarity, if the name acme-tools is intentional, please consider adding a comment explaining the relationship. For example:

"acme-tools": { // Marketplace for ACME's custom tools, hosted in a fork of cc-marketplace
  "source": {
    "source": "github",
    "repo": "kenryu42/cc-marketplace"
  }
}

Alternatively, if the name isn't a hard requirement, renaming it to something more descriptive like kenryu42-cc-marketplace would also resolve the potential confusion.

}
},
"permissions": {
"allow": [
"Bash(bun:*)",
Expand Down
5 changes: 4 additions & 1 deletion config/opencode/opencode.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
"apiKey": "{env:OPENROUTER_API_KEY}"
},
"models": {
"glm-4-6": {
"glm-4-7": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

The model key change from 'glm-4-6' to 'glm-4-7' removes the old configuration entirely. If this model reference is used elsewhere in your codebase or if the new model version is not yet available via OpenRouter, this could cause runtime failures. Consider: 1) Verifying the model is available in the OpenRouter API, 2) Adding a fallback mechanism, or 3) Temporarily keeping both versions during a transition period.

Agent: 🏛 Architecture • Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#527
File: config/opencode/opencode.jsonc#L199
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
The model key change from 'glm-4-6' to 'glm-4-7' removes the old configuration entirely. If this model reference is used elsewhere in your codebase or if the new model version is not yet available via OpenRouter, this could cause runtime failures. Consider: 1) Verifying the model is available in the OpenRouter API, 2) Adding a fallback mechanism, or 3) Temporarily keeping both versions during a transition period.

"id": "@preset/glm-4-7",
"name": "Preset GLM-4.7 (via OpenRouter)"
}
Expand Down Expand Up @@ -288,6 +288,9 @@
}
}
},
"plugin": [
"cc-safety-net"
],
"tui": {
"scroll_speed": 3
}
Expand Down
Loading