-
Notifications
You must be signed in to change notification settings - Fork 0
chore(config): update Claude and OpenCode plugin configurations #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -8,11 +8,20 @@ | |||||
| "frontend-design@claude-plugins-official": true, | ||||||
| "pr-review-toolkit@claude-plugins-official": true, | ||||||
| "code-simplifier@claude-plugins-official": true, | ||||||
| "ralph-wiggum@claude-plugins-official": true, | ||||||
| "ralph-loop@claude-plugins-official": true, | ||||||
| "serena@claude-plugins-official": true, | ||||||
| "typescript-lsp@claude-plugins-official": true, | ||||||
| "plan-export@cc-marketplace": true, | ||||||
| "safety-net@cc-marketplace": true | ||||||
| }, | ||||||
| "extraKnownMarketplaces": { | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding an external GitHub marketplace without version pinning or integrity verification creates a supply chain security risk. Consider: 1) Pinning to a specific commit hash or tag instead of the default branch, 2) Adding a verification mechanism to ensure plugin integrity, or 3) Documenting the security implications of using external marketplaces in your security policy. Prompt for Agent |
||||||
| "cc-marketplace": { | ||||||
| "source": { | ||||||
| "source": "github", | ||||||
|
||||||
| "source": "github", | |
| "type": "github", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The marketplace name acme-tools is generic and its connection to the source repository kenryu42/cc-marketplace isn't immediately obvious. This could be confusing for future developers maintaining this configuration.
To improve clarity, if the name acme-tools is intentional, please consider adding a comment explaining the relationship. For example:
"acme-tools": { // Marketplace for ACME's custom tools, hosted in a fork of cc-marketplace
"source": {
"source": "github",
"repo": "kenryu42/cc-marketplace"
}
}Alternatively, if the name isn't a hard requirement, renaming it to something more descriptive like kenryu42-cc-marketplace would also resolve the potential confusion.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -196,7 +196,7 @@ | |
| "apiKey": "{env:OPENROUTER_API_KEY}" | ||
| }, | ||
| "models": { | ||
| "glm-4-6": { | ||
| "glm-4-7": { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The model key change from 'glm-4-6' to 'glm-4-7' removes the old configuration entirely. If this model reference is used elsewhere in your codebase or if the new model version is not yet available via OpenRouter, this could cause runtime failures. Consider: 1) Verifying the model is available in the OpenRouter API, 2) Adding a fallback mechanism, or 3) Temporarily keeping both versions during a transition period. Prompt for Agent |
||
| "id": "@preset/glm-4-7", | ||
| "name": "Preset GLM-4.7 (via OpenRouter)" | ||
| } | ||
|
|
@@ -288,6 +288,9 @@ | |
| } | ||
| } | ||
| }, | ||
| "plugin": [ | ||
| "cc-safety-net" | ||
| ], | ||
| "tui": { | ||
| "scroll_speed": 3 | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming convention
safety-net@cc-marketplacein Claude's config differs fromcc-safety-netin OpenCode's config (line 292). This inconsistency could indicate: 1) Different plugin systems with different naming patterns, or 2) A configuration error where the plugins don't actually reference the same functionality. Verify that this naming difference is intentional and both plugins serve their intended purpose.Agent: 🏛 Architecture •
• 
Prompt for Agent