Skip to content

fix(claude): remove Nix management of known_marketplaces.json #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Jan 7, 2026
Merged

fix(claude): remove Nix management of known_marketplaces.json #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions config/claude/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,4 @@
source = ./statusline-git.sh;
executable = true;
};

@mesa-dot-dev mesa-dot-dev Bot Jan 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

The removal of known_marketplaces.json creates a potential bootstrap issue: settings.json (still managed by Nix) enables safety-net@cc-marketplace, but the cc-marketplace marketplace definition is no longer guaranteed to exist on fresh installations. Consider either:

  1. Adding a comment/documentation here about required post-install steps (/plugin marketplace add for cc-marketplace)
  2. Creating a Nix activation script that runs the Claude CLI command to add required marketplaces
  3. Re-evaluating whether safety-net@cc-marketplace should be enabled by default without guaranteed marketplace availability

This could cause Claude to fail loading the safety-net plugin until the user manually adds the marketplace.

Agent: 🏛 Architecture • Fix in Cursor • Fix in Claude

Prompt for Agent 
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#513
File: config/claude/default.nix#L25
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
The removal of `known_marketplaces.json` creates a potential bootstrap issue: `settings.json` (still managed by Nix) enables `safety-net@cc-marketplace`, but the `cc-marketplace` marketplace definition is no longer guaranteed to exist on fresh installations. Consider either:
1. Adding a comment/documentation here about required post-install steps (`/plugin marketplace add` for cc-marketplace)
2. Creating a Nix activation script that runs the Claude CLI command to add required marketplaces
3. Re-evaluating whether `safety-net@cc-marketplace` should be enabled by default without guaranteed marketplace availability

This could cause Claude to fail loading the safety-net plugin until the user manually adds the marketplace.


home.file.".claude/plugins/known_marketplaces.json" = {
source = ./known_marketplaces.json;
};
}
26 changes: 0 additions & 26 deletions config/claude/known_marketplaces.json
View file
Open in desktop

This file was deleted.

Loading