-
Notifications
You must be signed in to change notification settings - Fork 0
feat(claude): add safety-net plugin from cc-marketplace #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,26 @@ | ||||||||||||||||||
| { | ||||||||||||||||||
| "claude-code-plugins": { | ||||||||||||||||||
| "source": { | ||||||||||||||||||
| "source": "git", | ||||||||||||||||||
| "url": "https://github.com/anthropics/claude-code.git" | ||||||||||||||||||
| } | ||||||||||||||||||
| }, | ||||||||||||||||||
| "claude-plugins-official": { | ||||||||||||||||||
| "source": { | ||||||||||||||||||
| "source": "github", | ||||||||||||||||||
| "repo": "anthropics/claude-plugins-official" | ||||||||||||||||||
| } | ||||||||||||||||||
| }, | ||||||||||||||||||
| "anthropic-agent-skills": { | ||||||||||||||||||
| "source": { | ||||||||||||||||||
| "source": "github", | ||||||||||||||||||
| "repo": "anthropics/skills" | ||||||||||||||||||
| } | ||||||||||||||||||
| }, | ||||||||||||||||||
| "cc-marketplace": { | ||||||||||||||||||
| "source": { | ||||||||||||||||||
| "source": "git", | ||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The git URL for cc-marketplace should be pinned to a specific commit SHA or tag for reproducibility and security. Using the default branch means the plugin behavior could change unexpectedly between builds. Consider using a format like: "url": "https://github.com/kenryu42/cc-marketplace.git", "ref": "" to ensure deterministic builds, which aligns with Nix philosophy. Prompt for Agent |
||||||||||||||||||
| "url": "https://github.com/kenryu42/cc-marketplace.git" | ||||||||||||||||||
| } | ||||||||||||||||||
|
Comment on lines
+21
to
+24
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency with other marketplace definitions in this file, such as
Suggested change
|
||||||||||||||||||
| } | ||||||||||||||||||
| } | ||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file appears to duplicate built-in marketplace definitions. Lines 2-19 define 'claude-code-plugins', 'claude-plugins-official', and 'anthropic-agent-skills' which are likely already known to Claude Code internally. According to the comment in default.nix (line 27), Claude Code 'will merge with built-in ones', suggesting these duplicated definitions may be unnecessary. Consider removing the built-in marketplace definitions and only defining the custom 'cc-marketplace' to reduce maintenance burden and potential for configuration drift.
Agent: 🏛 Architecture •
• 
Prompt for Agent