Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/claude/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,8 @@
source = ./statusline-git.sh;
executable = true;
};

home.file.".claude/plugins/known_marketplaces.json" = {
source = ./known_marketplaces.json;
};
}
26 changes: 26 additions & 0 deletions config/claude/known_marketplaces.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"claude-code-plugins": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

This file appears to duplicate built-in marketplace definitions. Lines 2-19 define 'claude-code-plugins', 'claude-plugins-official', and 'anthropic-agent-skills' which are likely already known to Claude Code internally. According to the comment in default.nix (line 27), Claude Code 'will merge with built-in ones', suggesting these duplicated definitions may be unnecessary. Consider removing the built-in marketplace definitions and only defining the custom 'cc-marketplace' to reduce maintenance burden and potential for configuration drift.

Agent: 🏛 Architecture • Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#512
File: config/claude/known_marketplaces.json#L2
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
This file appears to duplicate built-in marketplace definitions. Lines 2-19 define 'claude-code-plugins', 'claude-plugins-official', and 'anthropic-agent-skills' which are likely already known to Claude Code internally. According to the comment in default.nix (line 27), Claude Code 'will merge with built-in ones', suggesting these duplicated definitions may be unnecessary. Consider removing the built-in marketplace definitions and only defining the custom 'cc-marketplace' to reduce maintenance burden and potential for configuration drift.

"source": {
"source": "git",
"url": "https://github.com/anthropics/claude-code.git"
}
},
"claude-plugins-official": {
"source": {
"source": "github",
"repo": "anthropics/claude-plugins-official"
}
},
"anthropic-agent-skills": {
"source": {
"source": "github",
"repo": "anthropics/skills"
}
},
"cc-marketplace": {
"source": {
"source": "git",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

The git URL for cc-marketplace should be pinned to a specific commit SHA or tag for reproducibility and security. Using the default branch means the plugin behavior could change unexpectedly between builds. Consider using a format like: "url": "https://github.com/kenryu42/cc-marketplace.git", "ref": "" to ensure deterministic builds, which aligns with Nix philosophy.

Agent: 🏛 Architecture • Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#512
File: config/claude/known_marketplaces.json#L22
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
The git URL for cc-marketplace should be pinned to a specific commit SHA or tag for reproducibility and security. Using the default branch means the plugin behavior could change unexpectedly between builds. Consider using a format like: "url": "https://github.com/kenryu42/cc-marketplace.git", "ref": "<commit-sha>" to ensure deterministic builds, which aligns with Nix philosophy.

"url": "https://github.com/kenryu42/cc-marketplace.git"
}
Comment on lines +21 to +24

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other marketplace definitions in this file, such as claude-plugins-official and anthropic-agent-skills, consider using the github source type instead of git. This would make the configuration more uniform and easier to read. The github source type is likely a shorthand for public GitHub repositories and should work for this marketplace as well.

Suggested change
"source": {
"source": "git",
"url": "https://github.com/kenryu42/cc-marketplace.git"
}
"source": {
"source": "github",
"repo": "kenryu42/cc-marketplace"
}

}
}
3 changes: 2 additions & 1 deletion config/claude/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"pr-review-toolkit@claude-plugins-official": true,
"ralph-wiggum@claude-plugins-official": true,
"serena@claude-plugins-official": true,
"typescript-lsp@claude-plugins-official": true
"typescript-lsp@claude-plugins-official": true,
"safety-net@cc-marketplace": true
},
"permissions": {
"allow": [
Expand Down
Loading