Skip to content

chore(deps): update package dependencies #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Jan 3, 2026
Merged

chore(deps): update package dependencies #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"ccusage": "^17.2.0",
"cline": "^1.0.8",
"open-composer": "^0.8.23",
"turbo": "^2.7.2",

@gemini-code-assist gemini-code-assist Bot Jan 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The new dependency turbo should also be added to the trustedDependencies array. Packages with native binaries or install scripts, like turbo, need to be explicitly trusted by bun to ensure they can be installed correctly.

Please add "turbo" to the trustedDependencies list, maintaining alphabetical order. For example:

  ...
  "trustedDependencies": [
    ...
    "open-composer",
    "turbo",
    "typescript"
  ]
  ...

Copilot AI Jan 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The turbo package has been added to dependencies but is missing from the trustedDependencies array. Since all other dependencies in this project are listed in trustedDependencies, and turbo includes platform-specific binaries with optional dependencies, it should be added to maintain consistency and ensure proper installation with Bun's security model.

Copilot uses AI. Check for mistakes.

@cubic-dev-ai cubic-dev-ai Bot Jan 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: turbo was added to dependencies but not to trustedDependencies. This breaks the established pattern in this project where all dependencies are also listed in trustedDependencies (required for bun to run lifecycle scripts). Consider adding "turbo" to the trustedDependencies array.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 29:

<comment>`turbo` was added to dependencies but not to `trustedDependencies`. This breaks the established pattern in this project where all dependencies are also listed in `trustedDependencies` (required for bun to run lifecycle scripts). Consider adding `&quot;turbo&quot;` to the `trustedDependencies` array.</comment>

<file context>
@@ -26,6 +26,7 @@
     &quot;ccusage&quot;: &quot;^17.2.0&quot;,
     &quot;cline&quot;: &quot;^1.0.8&quot;,
     &quot;open-composer&quot;: &quot;^0.8.23&quot;,
+    &quot;turbo&quot;: &quot;^2.7.2&quot;,
     &quot;typescript&quot;: &quot;^5.9.3&quot;
   },
</file context>
Fix with Cubic

@mesa-dot-dev mesa-dot-dev Bot Jan 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

Turbo is typically a build/monorepo orchestration tool rather than a runtime dependency. Consider moving this to devDependencies to avoid unnecessarily installing Turbo's platform-specific binaries in production environments or when others install this package.

Agent: 🏛 Architecture • Fix in Cursor • Fix in Claude

Prompt for Agent 
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#489
File: package.json#L29
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
Turbo is typically a build/monorepo orchestration tool rather than a runtime dependency. Consider moving this to `devDependencies` to avoid unnecessarily installing Turbo's platform-specific binaries in production environments or when others install this package.

@coderabbitai coderabbitai Bot Jan 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add "turbo" to trustedDependencies for consistency.

The new "turbo" dependency should also be added to the trustedDependencies array (lines 32-49) to maintain consistency with the existing pattern where all dependencies are mirrored in both sections.

🔎 Proposed fix

Add "turbo" to the trustedDependencies array in alphabetical order:

    "ccusage",
    "cline",
    "open-composer",
+   "turbo",
    "typescript"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"turbo": "^2.7.2",
"ccusage",
"cline",
"open-composer",
"turbo",
"typescript"
🤖 Prompt for AI Agents 
In package.json around line 29 (and trustedDependencies array at lines ~32-49),
the "turbo" dependency was added to dependencies but not mirrored in
trustedDependencies; add the string "turbo" into the trustedDependencies array
in alphabetical order with the same quoting/comma style as the other entries so
the two lists remain consistent.

"typescript": "^5.9.3"
},
"trustedDependencies": [
Expand Down
Loading