Skip to content
Merged

auto #481

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
"@getgrit/cli": "^0.1.0-alpha.1743007075",
"@github/copilot": "^0.0.373",
"@google/jules": "^0.1.42",
"@kaitranntt/ccs": "^7.11.1",
"@kaitranntt/ccs": "^7.12.1",
"@nanocollective/nanocoder": "^1.19.2",
"@pulumi/pulumi": "^3.214.0",
"@sourcegraph/amp": "^0.0.1767068037-gb2caa3",
"@typescript/native-preview": "^7.0.0-dev.20251229.1",
"@sourcegraph/amp": "^0.0.1767254483-g812f6b",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

Using caret range (^) on a 0.0.x package with timestamp-based versions is risky. Per semver, 0.0.x versions can introduce breaking changes at any time. The version format 0.0.1767254483-g812f6b appears to be a CI/nightly build. Consider either: (1) pinning to exact version without caret to prevent automatic breaking updates, or (2) establishing a validation process that tests AMP workflows before accepting auto-updates.

Agent: 🏛 Architecture • Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#481
File: package.json#L23
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
Using caret range (^) on a 0.0.x package with timestamp-based versions is risky. Per semver, 0.0.x versions can introduce breaking changes at any time. The version format `0.0.1767254483-g812f6b` appears to be a CI/nightly build. Consider either: (1) pinning to exact version without caret to prevent automatic breaking updates, or (2) establishing a validation process that tests AMP workflows before accepting auto-updates.

"@typescript/native-preview": "^7.0.0-dev.20260101.1",
Comment on lines +23 to +24

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This pull request updates @sourcegraph/amp and @typescript/native-preview to pre-release/development versions. Using development versions can introduce instability, bugs, or breaking changes unexpectedly. It is generally recommended to use stable releases for better predictability and reliability, especially if this codebase is used in production environments. If these are used for testing purposes, it might be acceptable, but it's a risk to be aware of.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

This is a dev/nightly build (7.0.0-dev.20260101.1) of TypeScript native preview. Dev builds can contain regressions or breaking changes. Ensure TypeScript build and type-checking commands are validated before merging. Consider documenting the testing strategy for dev dependency updates in the PR description or CI pipeline.

Agent: 🏛 Architecture • Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: shunkakinoki/dotfiles#481
File: package.json#L24
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
This is a dev/nightly build (7.0.0-dev.20260101.1) of TypeScript native preview. Dev builds can contain regressions or breaking changes. Ensure TypeScript build and type-checking commands are validated before merging. Consider documenting the testing strategy for dev dependency updates in the PR description or CI pipeline.

Comment on lines +23 to +24

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify existence of pre-release package versions on npm registry

echo "=== Checking @sourcegraph/amp ==="
npm view @sourcegraph/amp@0.0.1767254483-g812f6b 2>&1 | head -20

echo -e "\n=== Checking @typescript/native-preview ==="
npm view @typescript/native-preview@7.0.0-dev.20260101.1 2>&1 | head -20

echo -e "\n=== Latest versions of @sourcegraph/amp ==="
npm view @sourcegraph/amp dist-tags 2>&1

echo -e "\n=== Latest versions of @typescript/native-preview ==="
npm view @typescript/native-preview dist-tags 2>&1

Repository: shunkakinoki/dotfiles

Length of output: 1618


Consider the stability implications of pre-release and snapshot versions.

Both packages specify pre-release/development builds as dependencies:

  • @sourcegraph/amp uses a snapshot build (0.0.1767254483-g812f6b) with frequent releases (2052 versions tracked)
  • @typescript/native-preview uses a dev build explicitly designed as a preview package

While both versions are published and maintained as their authors' latest releases, relying on snapshot and preview builds introduces inherent stability risks compared to stable releases. Confirm this dependency strategy aligns with your project's stability requirements.

🤖 Prompt for AI Agents
In package.json lines 23-24, the dependencies use pre-release/snapshot versions
("@sourcegraph/amp": 0.0.* snapshot and "@typescript/native-preview": dev
preview) which can cause instability; replace them with stable semver releases
if available (update the version strings to the latest stable tags), or if
pre-release usage is intentional, document the decision in package.json or the
repo README and pin exact versions in package.json and lockfile to prevent
accidental upgrades, and add a note about monitoring/update cadence (or add an
automated dependabot/renovate rule) to manage risk.

"@vibe-kit/grok-cli": "^0.0.34",
"ccusage": "^17.2.0",
"cline": "^1.0.8",
Expand Down
Loading