feat(testing): add ShellSpec tests for all shell scripts

spec/brew_upgrader_spec.sh

@@ -0,0 +1,102 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC2329
+
+Describe 'brew-upgrader/upgrade.sh'
+SCRIPT="$PWD/home-manager/services/brew-upgrader/upgrade.sh"
+
+Describe 'brew upgrade command'
+setup() {
+  MOCK_BIN=$(mktemp -d)
+  MOCK_LOG="$MOCK_BIN/mock.log"
+  : >"$MOCK_LOG"
+  export MOCK_BIN MOCK_LOG
+
+  # Create mock brew in /opt/homebrew/bin
+  mkdir -p /tmp/mock_homebrew/bin
+  cat >/tmp/mock_homebrew/bin/brew <<'EOF'
+#!/usr/bin/env bash
+echo "brew $*"
+exit 0
+EOF
+  chmod +x /tmp/mock_homebrew/bin/brew
+
+  # Also create at the actual path the script uses
+  mkdir -p "$MOCK_BIN/opt/homebrew/bin"
+}
+
+cleanup() {
+  rm -rf "$MOCK_BIN" /tmp/mock_homebrew
+}
+
+Before 'setup'
+After 'cleanup'
+
+It 'calls brew upgrade'
+# Test by checking what the script would do
+When run bash -c "cat '$SCRIPT' | grep 'brew upgrade'"
+The output should include 'brew upgrade'
+End
+
+It 'uses /opt/homebrew/bin/brew path'
+When run bash -c "cat '$SCRIPT'"
+The output should include '/opt/homebrew/bin/brew'
+End
+End
+
+Describe 'script properties'
+It 'uses strict mode'
+When run bash -c "head -5 '$SCRIPT'"
+The output should include 'set -euo pipefail'
+End
+
+It 'uses bash shebang'
+When run bash -c "head -1 '$SCRIPT'"
+The output should include '#!/usr/bin/env bash'
+End
+
+It 'is a short script (less than 10 lines)'
+When run bash -c "wc -l < '$SCRIPT' | tr -d ' '"
+The output should eq '5'
+End
+End
+
+Describe 'error handling'
+setup() {
+  MOCK_BIN=$(mktemp -d)
+  mkdir -p "$MOCK_BIN/opt/homebrew/bin"
+
+  # Create failing brew mock
+  cat >"$MOCK_BIN/opt/homebrew/bin/brew" <<'EOF'
+#!/usr/bin/env bash
+echo "Error: brew failed" >&2
+exit 1
+EOF
+  chmod +x "$MOCK_BIN/opt/homebrew/bin/brew"
+}
+
+cleanup() {
+  rm -rf "$MOCK_BIN"
+}
+
+Before 'setup'
+After 'cleanup'
+
+It 'exits with failure when brew fails'
+# Create a test script that uses our mock
+TEMP_SCRIPT=$(mktemp)
+cat >"$TEMP_SCRIPT" <<EOF
+#!/usr/bin/env bash
+set -euo pipefail
+$MOCK_BIN/opt/homebrew/bin/brew upgrade
+EOF
+chmod +x "$TEMP_SCRIPT"
+
+When run bash "$TEMP_SCRIPT"
+The status should be failure
+The stderr should include 'Error: brew failed'
+
+rm -f "$TEMP_SCRIPT"
+End
+End
+
+End

spec/cliproxyapi_spec.sh

@@ -0,0 +1,103 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC2329
+
+Describe 'cliproxyapi/start.sh'
+SCRIPT="$PWD/home-manager/services/cliproxyapi/start.sh"
+
+Describe 'configuration handling'
+setup() {
+  TEMP_HOME=$(mktemp -d)
+  mkdir -p "$TEMP_HOME/.cli-proxy-api"
+  mkdir -p "$TEMP_HOME/dotfiles"
+
+  # Create template config
+  cat >"$TEMP_HOME/.cli-proxy-api/config.template.yaml" <<'YAML'
+api_key: __OPENROUTER_API_KEY__
+management_password: __CLIPROXY_MANAGEMENT_PASSWORD__
+YAML
+
+  # Create .env file
+  cat >"$TEMP_HOME/dotfiles/.env" <<'ENV'
+OPENROUTER_API_KEY=test_openrouter_key
+CLIPROXY_MANAGEMENT_PASSWORD=test_mgmt_password
+ENV
+}
+
+cleanup() {
+  rm -rf "$TEMP_HOME"
+}
+
+Before 'setup'
+After 'cleanup'
+
+It 'sources .env file when present'
+# Create a script that tests env sourcing
+cat >"$TEMP_HOME/test_env.sh" <<'EOF'
+#!/usr/bin/env bash
+set -euo pipefail
+ENV_FILE="$HOME/dotfiles/.env"
+if [ -f "$ENV_FILE" ]; then
+  set -a
+  source "$ENV_FILE"
+  set +a
+fi
+echo "OPENROUTER_API_KEY=$OPENROUTER_API_KEY"
+EOF
+chmod +x "$TEMP_HOME/test_env.sh"
+
+When run bash -c "HOME='$TEMP_HOME' bash '$TEMP_HOME/test_env.sh'"
+The output should include 'OPENROUTER_API_KEY=test_openrouter_key'
+The status should be success
+End
+
+It 'generates config from template'
+# Create a simplified test script
+cat >"$TEMP_HOME/test_config.sh" <<'EOF'
+#!/usr/bin/env bash
+set -euo pipefail
+CONFIG_DIR="$HOME/.cli-proxy-api"
+TEMPLATE="$CONFIG_DIR/config.template.yaml"
+CONFIG="$CONFIG_DIR/config.yaml"
+
+OPENROUTER_API_KEY="test_key"
+CLIPROXY_MANAGEMENT_PASSWORD="test_pass"
+
+if [ -f "$TEMPLATE" ]; then
+  sed -e "s|__OPENROUTER_API_KEY__|${OPENROUTER_API_KEY:-}|g" \
+    -e "s|__CLIPROXY_MANAGEMENT_PASSWORD__|${CLIPROXY_MANAGEMENT_PASSWORD:-}|g" \
+    "$TEMPLATE" >"$CONFIG"
+fi
+cat "$CONFIG"
+EOF
+chmod +x "$TEMP_HOME/test_config.sh"
+
+When run bash -c "HOME='$TEMP_HOME' bash '$TEMP_HOME/test_config.sh'"
+The output should include 'api_key: test_key'
+The output should include 'management_password: test_pass'
+The status should be success
+End
+End
+
+Describe 'binary detection logic'
+It 'checks /opt/homebrew/bin/cliproxyapi first'
+When run bash -c "grep -A 2 'if.*-x.*/opt/homebrew/bin/cliproxyapi' '$SCRIPT'"
+The output should include '/opt/homebrew/bin/cliproxyapi'
+End
+
+It 'checks /usr/local/bin/cliproxyapi as fallback'
+When run bash -c "grep '/usr/local/bin/cliproxyapi' '$SCRIPT'"
+The output should include '/usr/local/bin/cliproxyapi'
+End
+
+It 'shows error message when binary not found'
+When run bash -c "grep 'cliproxyapi binary not found' '$SCRIPT'"
+The output should include 'cliproxyapi binary not found'
+End
+
+It 'suggests installation command in error message'
+When run bash -c "grep 'brew install cliproxyapi' '$SCRIPT'"
+The output should include 'brew install cliproxyapi'
+End
+End
+
+End

spec/code_syncer_spec.sh

@@ -0,0 +1,152 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC2329
+
+Describe 'code-syncer/sync.sh'
+SCRIPT="$PWD/home-manager/services/code-syncer/sync.sh"
+
+Describe 'VS Code CLI detection'
+setup() {
+  TEMP_HOME=$(mktemp -d)
+  mkdir -p "$TEMP_HOME/Library/Application Support/Code/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Cursor/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Windsurf/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Antigravity/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Code - Insiders/User"
+}
+
+cleanup() {
+  rm -rf "$TEMP_HOME"
+}
+
+Before 'setup'
+After 'cleanup'
+
+It 'exits with error when VS Code CLI not found'
+When run bash -c "HOME='$TEMP_HOME' bash '$SCRIPT' 2>&1"
+The output should include 'VS Code CLI not found'
+The status should be failure
+End
+End
+
+Describe 'extension filtering'
+setup() {
+  mock_bin_setup code fswatch
+  TEMP_HOME=$(mktemp -d)
+
+  # Create required directories
+  mkdir -p "$TEMP_HOME/Library/Application Support/Code/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Cursor/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Windsurf/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Antigravity/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Code - Insiders/User"
+
+  # Create mock VS Code CLI that lists extensions
+  cat >"$MOCK_BIN/code" <<'EOF'
+#!/usr/bin/env bash
+: "${MOCK_LOG:?MOCK_LOG must be set}"
+if [[ "$1" == "--list-extensions" ]]; then
+  echo "esbenp.prettier-vscode"
+  echo "github.copilot"
+  echo "ms-python.python"
+  echo "bradlc.vscode-tailwindcss"
+fi
+printf '%s\n' "code $*" >>"$MOCK_LOG"
+exit 0
+EOF
+  chmod +x "$MOCK_BIN/code"
+}
+
+cleanup() {
+  rm -rf "$TEMP_HOME"
+  mock_bin_cleanup
+}
+
+Before 'setup'
+After 'cleanup'
+
+It 'lists VS Code extensions'
+When run bash -c "HOME='$TEMP_HOME' bash '$SCRIPT' 2>&1 | head -20"
+The output should include 'extension'
+The status should be success
+End
+End
+
+Describe 'proprietary extension blocklist'
+It 'defines proprietary extensions to filter'
+When run bash -c "grep -A 20 'PROPRIETARY_EXTENSIONS=' '$SCRIPT' | head -20"
+The output should include 'github.copilot'
+The output should include 'ms-python.python'
+The output should include 'ms-vscode-remote'
+End
+
+It 'defines AI extensions to filter'
+When run bash -c "grep -A 20 'AI_EXTENSIONS=' '$SCRIPT' | head -20"
+The output should include 'github.copilot'
+The output should include 'anthropic.claude-code'
+End
+End
+
+Describe 'config file syncing'
+setup() {
+  mock_bin_setup code fswatch cp
+  TEMP_HOME=$(mktemp -d)
+
+  # Create VS Code user directory with config files
+  VSCODE_DIR="$TEMP_HOME/Library/Application Support/Code/User"
+  mkdir -p "$VSCODE_DIR"
+  echo '{"editor.fontSize": 14}' >"$VSCODE_DIR/settings.json"
+  echo '[]' >"$VSCODE_DIR/keybindings.json"
+
+  # Create target directories
+  mkdir -p "$TEMP_HOME/Library/Application Support/Cursor/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Windsurf/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Antigravity/User"
+  mkdir -p "$TEMP_HOME/Library/Application Support/Code - Insiders/User"
+
+  # Create code mock
+  cat >"$MOCK_BIN/code" <<'EOF'
+#!/usr/bin/env bash
+: "${MOCK_LOG:?MOCK_LOG must be set}"
+if [[ "$1" == "--list-extensions" ]]; then
+  echo "esbenp.prettier-vscode"
+fi
+printf '%s\n' "code $*" >>"$MOCK_LOG"
+exit 0
+EOF
+  chmod +x "$MOCK_BIN/code"
+}
+
+cleanup() {
+  rm -rf "$TEMP_HOME"
+  mock_bin_cleanup
+}
+
+Before 'setup'
+After 'cleanup'
+
+It 'copies settings.json to target editors'
+When run bash -c "HOME='$TEMP_HOME' bash '$SCRIPT' 2>&1 | head -30"
+The output should include 'settings.json'
+The status should be success
+End
+
+It 'copies keybindings.json to target editors'
+When run bash -c "HOME='$TEMP_HOME' bash '$SCRIPT' 2>&1 | head -30"
+The output should include 'keybindings.json'
+The status should be success
+End
+End
+
+Describe 'fswatch integration'
+It 'checks for fswatch availability'
+When run bash -c "grep 'fswatch' '$SCRIPT'"
+The output should include 'fswatch'
+End
+
+It 'shows message when fswatch not found'
+When run bash -c "grep -A 2 'fswatch not found' '$SCRIPT'"
+The output should include 'Auto-sync disabled'
+End
+End
+
+End