Skip to content

refactor: improve formatting in service configurations #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Dec 6, 2025
Merged

refactor: improve formatting in service configurations #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion home-manager/services/cliproxyapi/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ in
};
Service = {
Type = "simple";
Environment = "PATH=${lib.makeBinPath [ pkgs.gnused pkgs.bash ]}";
Environment = "PATH=${
lib.makeBinPath [
pkgs.gnused
pkgs.bash

@gemini-code-assist gemini-code-assist Bot Dec 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The start.sh script is executed with an absolute path to bash via ExecStart, and the script itself does not invoke bash. Therefore, adding pkgs.bash to the PATH environment variable is redundant. You can remove it to keep the service's environment minimal.

]
}";
ExecStart = "${pkgs.bash}/bin/bash ${./start.sh}";
Restart = "always";
RestartSec = 3;
Expand Down
7 changes: 6 additions & 1 deletion home-manager/services/neverssl-keepalive/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@ in
};
Service = {
Type = "oneshot";
Environment = "PATH=${lib.makeBinPath [ pkgs.curl pkgs.bash ]}";
Environment = "PATH=${
lib.makeBinPath [
pkgs.curl
pkgs.bash

@gemini-code-assist gemini-code-assist Bot Dec 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The keepalive.sh script is executed with an absolute path to bash via ExecStart, and the script itself only uses curl. Therefore, adding pkgs.bash to the PATH environment variable is redundant. You can remove it to keep the service's environment minimal.

]
}";
ExecStart = "${pkgs.bash}/bin/bash ${./keepalive.sh}";
};
};
Expand Down
2 changes: 1 addition & 1 deletion home-manager/services/neverssl-keepalive/keepalive.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
set -euo pipefail

# Silently ping neverssl.com - ignore failures (network may be unavailable)
curl -fsS --max-time 10 http://neverssl.com > /dev/null 2>&1 || true
curl -fsS --max-time 10 http://neverssl.com >/dev/null 2>&1 || true
Loading