-
Notifications
You must be signed in to change notification settings - Fork 0
devenv #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devenv #369
Changes from all commits
2947060
1f7dd33
e330861
2af265d
b69008c
ad87e69
5026a98
f139a19
ac9cdcf
52bae23
09fcbb2
8e49fdb
45df727
e1d33b2
0678a07
25f4b30
e20f3f3
3be37d4
4009ba2
52cf65a
4bad055
d5eb25d
07930dc
cf7638b
37c2738
eb937ae
2f74fce
a26d4bf
939ffda
30dff45
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| # AI | ||
| .claude | ||
| .devenv.nix | ||
|
|
||
| # Nix | ||
| .devenv | ||
| *.hm-backup | ||
|
|
||
| # General | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,7 @@ | ||||||
| ##@ Variables | ||||||
|
|
||||||
| # Include rules from submodule | ||||||
| # Include rules from submodule but keep the local help target authoritative. | ||||||
| RULES_SKIP_HELP := 1 | ||||||
| -include rules/Makefile | ||||||
|
|
||||||
| # Detect architecture and OS | ||||||
|
|
@@ -25,6 +26,11 @@ DOCKER_IMAGE_TAGGED := $(DOCKER_IMAGE_NAME_BASE):$(GIT_COMMIT_SHA) | |||||
| # Nix executable path | ||||||
| NIX_EXEC := $(shell which nix) | ||||||
|
|
||||||
| # Common cache settings (apply even before switch) | ||||||
| NIX_SUBSTITUTERS := https://cache.nixos.org https://devenv.cachix.org https://cachix.cachix.org | ||||||
| NIX_TRUSTED_KEYS := cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= devenv.cachix.org-1:w1cLUi8dv3hnoSPGAuibQv+f9TZLr6cv/Hm9XgU50cw= cachix.cachix.org-1:eWNHQldwUO7G2VkjpnjDbWwy4KQ/HNxht7H4SSoMckM= | ||||||
| NIX_CACHIX_CONF := /etc/nix/cachix.conf | ||||||
|
||||||
| NIX_CACHIX_CONF := /etc/nix/cachix.conf |
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag --no-pure-eval is redundant when used with --impure. Both flags enable impure evaluation, so only --impure is needed. Consider removing --no-pure-eval for clarity.
| NIX_FLAGS := --extra-experimental-features 'flakes nix-command' --no-pure-eval --impure | |
| NIX_FLAGS := --extra-experimental-features 'flakes nix-command' --impure |
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated comment says "Set up Nix environment (install, check, connect, trust caches)." but the nix-setup target doesn't include any explicit cache-trusting step. The cache configuration is now applied via NIX_FLAGS in all Nix commands, but there's no separate "trust caches" action in the target dependencies. Consider updating the comment to be more accurate, e.g., "Set up Nix environment (install, check, connect)."
| nix-setup: nix-install nix-check nix-connect ## Set up Nix environment (install, check, connect, trust caches). | |
| nix-setup: nix-install nix-check nix-connect ## Set up Nix environment (install, check, connect). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,13 @@ | ||
| [ | ||
| ./codex | ||
| ./crush | ||
| ./claude | ||
| ./direnv | ||
| ./ghostty | ||
| ./hammerspoon | ||
| ./karabiner | ||
| ./nvim | ||
| ./opencode | ||
| ./serena | ||
| ./starship | ||
| ] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { pkgs }: | ||
|
|
||
| { | ||
| packages = [ | ||
| pkgs.nodejs | ||
| pkgs.bun | ||
| pkgs.neovim | ||
| ]; | ||
|
|
||
| containers = pkgs.lib.mkIf (!pkgs.stdenv.hostPlatform.isLinux) (pkgs.lib.mkForce { }); | ||
|
|
||
| enterShell = '' | ||
| echo "Dev shell ready: Node.js, bun, and Neovim available." | ||
| ''; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding inline comments explaining why these specific cachix substituters (devenv.cachix.org and cachix.cachix.org) are required, especially since this is a new addition. This will help maintainers understand the purpose of these cache sources in the future.