Update package configurations and fix Zsh settings #345
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,69 @@ | ||||||||||
| { | ||||||||||
| # From: https://github.com/henrysipp/omarchy-nix/blob/308e0f85a0deb820c01cfbe1b4faee1daab4da12/modules/home-manager/btop.nix | ||||||||||
| programs.btop = { | ||||||||||
| enable = true; | ||||||||||
| settings = { | ||||||||||
| theme_background = false; | ||||||||||
| truecolor = true; | ||||||||||
| force_tty = false; | ||||||||||
| vim_keys = true; | ||||||||||
| rounded_corners = true; | ||||||||||
| graph_symbol = "braille"; | ||||||||||
| graph_symbol_cpu = "default"; | ||||||||||
| graph_symbol_mem = "default"; | ||||||||||
| graph_symbol_net = "default"; | ||||||||||
| graph_symbol_proc = "default"; | ||||||||||
| shown_boxes = "cpu mem net proc"; | ||||||||||
| update_ms = 2000; | ||||||||||
| proc_sorting = "cpu lazy"; | ||||||||||
| proc_reversed = false; | ||||||||||
| proc_tree = false; | ||||||||||
| proc_colors = true; | ||||||||||
| proc_gradient = false; | ||||||||||
| proc_per_core = false; | ||||||||||
| proc_mem_bytes = true; | ||||||||||
| proc_cpu_graphs = true; | ||||||||||
| proc_info_smaps = false; | ||||||||||
| proc_left = false; | ||||||||||
| cpu_graph_upper = "total"; | ||||||||||
| cpu_graph_lower = "total"; | ||||||||||
| cpu_invert_lower = true; | ||||||||||
| cpu_single_graph = false; | ||||||||||
| cpu_bottom = false; | ||||||||||
| show_uptime = true; | ||||||||||
| check_temp = true; | ||||||||||
| cpu_sensor = "Auto"; | ||||||||||
| show_coretemp = true; | ||||||||||
| cpu_core_map = ""; | ||||||||||
| temp_scale = "celsius"; | ||||||||||
| base_10_sizes = false; | ||||||||||
| show_cpu_freq = true; | ||||||||||
| clock_format = "%X"; | ||||||||||
| background_update = true; | ||||||||||
| custom_cpu_name = "; | ||||||||||
|
There was a problem hiding this comment. Syntax error: The string value is not properly closed. This line should be: custom_cpu_name = "";
Suggested change
Contributor
There was a problem hiding this comment. The string literal here is missing its closing quote, so the Nix module will fail to parse. Please close the string. Prompt for AI agents
Suggested change
|
||||||||||
| disks_filter = "; | ||||||||||
|
Comment on lines
+43
to
+44
There was a problem hiding this comment.
The new btop module sets several options to Useful? React with 👍 / 👎. There was a problem hiding this comment. Syntax error: The string value is not properly closed. This line should be: disks_filter = "";
Suggested change
Comment on lines
+43
to
+44
There was a problem hiding this comment. Fix malformed string literals - missing opening quotes. Several string settings have syntax errors with only a closing quote and semicolon. These will cause Nix evaluation to fail. Apply this diff to fix the malformed strings: clock_format = "%X";
background_update = true;
- custom_cpu_name = ";
- disks_filter = ";
+ custom_cpu_name = "";
+ disks_filter = "";
mem_graphs = true; io_mode = false;
io_graph_combined = false;
- io_graph_speeds = ";
+ io_graph_speeds = "";
net_download = 100; net_auto = true;
net_sync = true;
- net_iface = ";
+ net_iface = "";
show_battery = true;Also applies to: 58-58, 63-63 🤖 Prompt for AI Agents
Contributor
There was a problem hiding this comment. This assignment is missing the closing quote, leaving the string unterminated and breaking the configuration. Close the string literal. Prompt for AI agents
Suggested change
|
||||||||||
| mem_graphs = true; | ||||||||||
| mem_below_net = false; | ||||||||||
| zfs_arc_cached = true; | ||||||||||
| show_swap = true; | ||||||||||
| swap_disk = true; | ||||||||||
| show_disks = true; | ||||||||||
| only_physical = true; | ||||||||||
| use_fstab = true; | ||||||||||
| zfs_hide_datasets = false; | ||||||||||
| disk_free_priv = false; | ||||||||||
| show_io_stat = true; | ||||||||||
| io_mode = false; | ||||||||||
| io_graph_combined = false; | ||||||||||
| io_graph_speeds = "; | ||||||||||
|
There was a problem hiding this comment. Syntax error: The string value is not properly closed. This line should be: io_graph_speeds = "";
Suggested change
Contributor
There was a problem hiding this comment. The new Prompt for AI agents
Suggested change
|
||||||||||
| net_download = 100; | ||||||||||
| net_upload = 100; | ||||||||||
| net_auto = true; | ||||||||||
| net_sync = true; | ||||||||||
| net_iface = "; | ||||||||||
|
Comment on lines
+43
to
+63
Contributor
There was a problem hiding this comment. There are several syntax errors in this block. The string values for There was a problem hiding this comment. Syntax error: The string value is not properly closed. This line should be: net_iface = "";
Suggested change
Contributor
There was a problem hiding this comment. The Prompt for AI agents
Suggested change
|
||||||||||
| show_battery = true; | ||||||||||
| selected_battery = "Auto"; | ||||||||||
| log_level = "WARNING"; | ||||||||||
| }; | ||||||||||
| }; | ||||||||||
|
Comment on lines
+1
to
+68
There was a problem hiding this comment. ❓ Verification inconclusiveConsider verifying btop configuration options. The btop configuration contains extensive settings copied from a reference repository. While the structure looks correct (aside from the string literal issues), you may want to verify these settings match your preferred btop behavior. Run this script to check the btop package and review available configuration options: 🏁 Script executed: #!/bin/bash
# Description: Verify btop is available in nixpkgs and check for documentation
# Check if btop exists in nixpkgs
nix-env -qaP -A nixpkgs.btop
# Look for btop home-manager module documentation
fd -e nix btop | head -20Length of output: 45 I'll search for documentation on Nix syntax to verify the string literal issues are indeed errors: Fix critical syntax errors in btop configuration. The btop settings contain unclosed string literals that will cause Nix evaluation to fail. In Nix, strings are enclosed between double quotes, and each of the following assignments is missing the opening quote:
These errors will prevent the module from loading. If these settings should have specific values, provide them; otherwise, use empty strings as shown above. 🤖 Prompt for AI Agents |
||||||||||
| } | ||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| { | ||
| programs.direnv = { | ||
| enable = true; | ||
| enableBashIntegration = true; | ||
| # enableFishIntegration = true; | ||
| enableZshIntegration = true; | ||
| nix-direnv.enable = true; | ||
|
Comment on lines
+4
to
+7
Contributor
There was a problem hiding this comment. Enabling |
||
| }; | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |||||||||
| { lib, pkgs, ... }: | ||||||||||
| { | ||||||||||
| programs.zsh = { | ||||||||||
| enable = true; | ||||||||||
|
There was a problem hiding this comment. Enabling Zsh alongside Fish (which is already extensively configured with functions, completions, and shell integrations) creates potential conflicts. Multiple enabled shells can cause login shell priority issues, conflicting shell integrations, and environment variable initialization order problems. Consider clarifying which shell is primary or documenting if this is a migration path from Fish to Zsh. Agent: 🏛 Architecture • |
||||||||||
| enableCompletion = true; | ||||||||||
| autosuggestion.enable = true; | ||||||||||
| syntaxHighlighting.enable = true; | ||||||||||
|
|
@@ -17,7 +17,7 @@ | |||||||||
| extended = true; | ||||||||||
| }; | ||||||||||
|
|
||||||||||
| initContent = '' | ||||||||||
|
Contributor
There was a problem hiding this comment. The There was a problem hiding this comment. The attribute name Change this back to: initExtra = ''
Suggested change
There was a problem hiding this comment. Incorrect attribute name - should be The standard home-manager Zsh module attribute for shell initialization is Apply this diff to fix the attribute name: - initContent = ''
+ initExtra = ''📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsThere was a problem hiding this comment. The Agent: 🏛 Architecture •
Contributor
There was a problem hiding this comment. Using Prompt for AI agents |
||||||||||
| # Initialize Starship | ||||||||||
| eval "$(starship init zsh)" | ||||||||||
|
|
||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid impure
builtins.getEnvfor environment-dependent logic.Using
builtins.getEnvbreaks Nix's reproducibility guarantees because it reads from the environment at evaluation time. This can cause:Consider passing
isCIas a function parameter instead:Then pass the value from the calling module based on your build context. This maintains purity while achieving the same goal.
🤖 Prompt for AI Agents