Skip to content

feat: add custom key bindings for exiting vim insert mode in fish shell #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 2 commits into from
Oct 12, 2025
Merged

feat: add custom key bindings for exiting vim insert mode in fish shell #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddff84e
feat: add custom key bindings for exiting vim insert mode in fish shell
shunkakinoki Oct 12, 2025
be836f5
feat: restore fish user key bindings for exiting vim insert mode
shunkakinoki Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,15 @@ jobs:
with:
images: ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }}
flavor: |
suffix=${{ github.ref == 'refs/heads/main' && github.event_name == 'push' && matrix.build.suffix || '' }}
suffix=${{ matrix.build.suffix }}
latest=${{ github.ref == 'refs/heads/main' && github.event_name == 'push' && 'false' || 'auto' }}

Copilot AI Oct 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest tag logic is inverted. When on main branch with push event, it sets latest='false', but the following tags suggest it should be 'true' or 'auto'. This will prevent the latest tag from being applied when expected.

Suggested change
latest=${{ github.ref == 'refs/heads/main' && github.event_name == 'push' && 'false' || 'auto' }}
latest=${{ github.ref == 'refs/heads/main' && github.event_name == 'push' && 'true' || 'false' }}

Copilot uses AI. Check for mistakes.
tags: |
type=sha,format=short
type=semver,pattern={{version}}
type=semver,pattern={{raw}}
type=raw,value=latest,enable=${{ github.ref == 'refs/heads/main' && github.event_name == 'push' }}
type=sha,format=short,suffix=${{ matrix.build.suffix }},enable=${{ github.ref == 'refs/heads/main' && github.event_name == 'push' }}
type=raw,value=latest,suffix=${{ matrix.build.suffix }},enable=${{ github.ref == 'refs/heads/main' && github.event_name == 'push' }}
type=sha,format=short,enable=${{ !(github.ref == 'refs/heads/main' && github.event_name == 'push') }}
type=semver,pattern={{version}},enable=${{ !(github.ref == 'refs/heads/main' && github.event_name == 'push') }}

@cubic-dev-ai cubic-dev-ai Bot Oct 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new enable=${{ !(github.ref == 'refs/heads/main' && github.event_name == 'push') }} on the semver tag entries disables semver tags during main pushes, so release builds never publish vX.Y.Z-<arch> images. The manifest job still expects those tags and will fail to assemble multi-arch semver manifests, leaving release tags missing from GHCR.

Prompt for AI agents 
Address the following comment on .github/workflows/docker.yml at line 49:

<comment>The new `enable=${{ !(github.ref == &#39;refs/heads/main&#39; &amp;&amp; github.event_name == &#39;push&#39;) }}` on the semver tag entries disables semver tags during main pushes, so release builds never publish `vX.Y.Z-&lt;arch&gt;` images. The manifest job still expects those tags and will fail to assemble multi-arch semver manifests, leaving release tags missing from GHCR.</comment>

<file context>
@@ -40,12 +40,15 @@ jobs:
+            type=sha,format=short,suffix=${{ matrix.build.suffix }},enable=${{ github.ref == &#39;refs/heads/main&#39; &amp;&amp; github.event_name == &#39;push&#39; }}
+            type=raw,value=latest,suffix=${{ matrix.build.suffix }},enable=${{ github.ref == &#39;refs/heads/main&#39; &amp;&amp; github.event_name == &#39;push&#39; }}
+            type=sha,format=short,enable=${{ !(github.ref == &#39;refs/heads/main&#39; &amp;&amp; github.event_name == &#39;push&#39;) }}
+            type=semver,pattern={{version}},enable=${{ !(github.ref == &#39;refs/heads/main&#39; &amp;&amp; github.event_name == &#39;push&#39;) }}
+            type=semver,pattern={{raw}},enable=${{ !(github.ref == &#39;refs/heads/main&#39; &amp;&amp; github.event_name == &#39;push&#39;) }}
+            type=raw,value=latest,enable=${{ !(github.ref == &#39;refs/heads/main&#39; &amp;&amp; github.event_name == &#39;push&#39;) }}
</file context>
Fix with Cubic

type=semver,pattern={{raw}},enable=${{ !(github.ref == 'refs/heads/main' && github.event_name == 'push') }}
type=raw,value=latest,enable=${{ !(github.ref == 'refs/heads/main' && github.event_name == 'push') }}

Copilot AI Oct 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition enables the 'latest' tag when NOT on main branch with push event, which contradicts typical Docker tagging conventions where 'latest' should only be applied to main branch releases.

Suggested change
type=raw,value=latest,enable=${{ !(github.ref == 'refs/heads/main' && github.event_name == 'push') }}

Copilot uses AI. Check for mistakes.
labels: |
org.opencontainers.image.url=${{ github.server_url }}/${{ github.repository }}
org.opencontainers.image.source=${{ github.event.pull_request.html_url || github.event.repository.html_url }}
Expand Down
1 change: 1 addition & 0 deletions home-manager/programs/fish/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
cs = "claude-squad";
cx = "codex exec";
e = "nvim";
g = "git";
ld = "lazydocker";
lg = "lazygit";
ta = "tmux new -A -s default";
Expand Down
4 changes: 4 additions & 0 deletions home-manager/programs/fish/functions/_fish_user_key_bindings.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
function fish_user_key_bindings
# Exit vim insert mode with jj
bind -M insert -m default jj backward-char force-repaint
end