Skip to content

feat: set vi mode as default key bindings in fish shell #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Oct 12, 2025
Merged

feat: set vi mode as default key bindings in fish shell #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions home-manager/programs/fish/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
fish_add_path -p /etc/profiles/per-user/${config.home.username}/bin
set -a fish_complete_path ~/.nix-profile/share/fish/completions/ ~/.nix-profile/share/fish/vendor_completions.d/
set -x FISH_HISTFILE fish
fish_vi_key_bindings

@gemini-code-assist gemini-code-assist Bot Oct 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this works, a more idiomatic and declarative way to set key bindings in home-manager is to use the keyBindings option within the programs.fish block. This improves maintainability by keeping configuration declarative.

You should remove this line and instead add keyBindings = "vi"; to your programs.fish configuration, for example, after enable = true;.

'';
shellAliases = {
neofetch = "fastfetch";
Expand All @@ -46,10 +47,6 @@
ta = "tmux new -A -s default";
v = "nvim";

# Git abbreviations - provided by GitAlias (see shellInit)
# Only keeping custom ones that differ from GitAlias or have special behavior
gpn = "git push --no-verify"; # Custom: not in GitAlias
Comment on lines 49 to -51

@gemini-code-assist gemini-code-assist Bot Oct 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This removal of the gpn alias and its related comments seems unrelated to the main purpose of this pull request, which is to enable vi mode. To keep commits atomic and easy to review and revert, it's best to group related changes into a single PR. Please consider moving this change to a separate pull request.


# Function-based abbreviations
cxe = "_cxe_function";
clxe = "_clxe_function";
Expand Down