Skip to content

feat(fish): prioritize ~/.local/bin in PATH #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 3 commits into from
Oct 5, 2025
Merged

feat(fish): prioritize ~/.local/bin in PATH #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7db0887
feat(fish): prioritize ~/.local/bin in PATH
shunkakinoki Oct 4, 2025
4eff505
fix(npm-globals): prioritize ~/.local/bin in sessionPath
shunkakinoki Oct 4, 2025
291354b
fix(npm-globals): simplify comment for sessionPath configuration
shunkakinoki Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion home-manager/modules/npm-globals/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@
fi
'';

# Add bun bin to PATH
# Add local and bun bins to PATH
home.sessionPath = [
"$HOME/.local/bin"
"$HOME/.bun/bin"
];
}
2 changes: 2 additions & 0 deletions home-manager/programs/fish/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
direnv hook fish | source
'';
loginShellInit = ''
fish_add_path -p ~/.local/bin
fish_add_path -p ~/.bun/bin
Comment on lines +9 to 10

Copilot AI Oct 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same PATH configuration is duplicated between loginShellInit and interactiveShellInit. Consider extracting this into a shared variable or function to reduce duplication and ensure consistency.

Copilot uses AI. Check for mistakes.
fish_add_path -p ~/.nix-profile/bin
fish_add_path -p /nix/var/nix/profiles/default/bin
Comment on lines 8 to 12

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 4, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge fish_add_path order keeps ~/.local/bin lowest priority

fish_add_path -p prepends each path to the front of $PATH, so later calls have higher precedence than earlier ones. Because this block ends with /etc/profiles/per-user/... and ~/.bun/bin, inserting fish_add_path -p ~/.local/bin at the top still leaves ~/.local/bin behind ~/.bun/bin in the final PATH. The change therefore does not fix the stated issue—open-composer will still resolve to the bun wrapper. To actually prioritize ~/.local/bin, it needs to be the last -p call (or the others should append instead).

Useful? React with 👍 / 👎.

Expand All @@ -17,6 +18,7 @@
_hm_load_env_file
set fish_greeting
set fish_theme dracula
fish_add_path -p ~/.local/bin
fish_add_path -p ~/.bun/bin
fish_add_path -p ~/.nix-profile/bin
fish_add_path -p /nix/var/nix/profiles/default/bin
Expand Down