chore: upgrade - #2365
Conversation
|
Warning Indent Zero is shutting down on August 7th. Please migrate over to Indent 2.0 to continue getting PR reviews.
|
|
Warning Review limit reached
Next review available in: 57 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Changesmoshi-hook update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![indent-zero[bot]](https://avatars.githubusercontent.com/in/1426746?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="config/omp/config.yml">
<violation number="1" location="config/omp/config.yml:318">
P2: `openai-codex/__GPT_CODEX_SPARK__` is an unresolved placeholder in the hydrated config. `scripts/llm-update.sh` substitutes `__PLACEHOLDER__` tokens only from `models.json` keys plus the two `add_model_override` calls (gpt-image, deepseek-flash), and `models.json` has no `gpt-codex-spark` key. Rerunning the script leaves the token literal, so the `default` fallback chain at runtime contains the invalid model `openai-codex/__GPT_CODEX_SPARK__`, which is never resolvable and drops the intended spark candidate. It also breaks the existing contract in `spec/llm_update_spec.sh:188`, which asserts `fallbackChains.default == ["openai-codex/gpt-5.6-luna","openai-codex/gpt-5.3-codex-spark","openai-codex/gpt-5.6-sol"]`. Add a `gpt-codex-spark` entry to `models.json` (or an override in `llm-update.sh`) so the placeholder resolves to a concrete model, or revert the line to a concrete value, and update the spec accordingly.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| default: | ||
| - "openai-codex/gpt-5.6-luna" | ||
| - "openai-codex/gpt-5.3-codex-spark" | ||
| - "openai-codex/__GPT_CODEX_SPARK__" |
There was a problem hiding this comment.
P2: openai-codex/__GPT_CODEX_SPARK__ is an unresolved placeholder in the hydrated config. scripts/llm-update.sh substitutes __PLACEHOLDER__ tokens only from models.json keys plus the two add_model_override calls (gpt-image, deepseek-flash), and models.json has no gpt-codex-spark key. Rerunning the script leaves the token literal, so the default fallback chain at runtime contains the invalid model openai-codex/__GPT_CODEX_SPARK__, which is never resolvable and drops the intended spark candidate. It also breaks the existing contract in spec/llm_update_spec.sh:188, which asserts fallbackChains.default == ["openai-codex/gpt-5.6-luna","openai-codex/gpt-5.3-codex-spark","openai-codex/gpt-5.6-sol"]. Add a gpt-codex-spark entry to models.json (or an override in llm-update.sh) so the placeholder resolves to a concrete model, or revert the line to a concrete value, and update the spec accordingly.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At config/omp/config.yml, line 318:
<comment>`openai-codex/__GPT_CODEX_SPARK__` is an unresolved placeholder in the hydrated config. `scripts/llm-update.sh` substitutes `__PLACEHOLDER__` tokens only from `models.json` keys plus the two `add_model_override` calls (gpt-image, deepseek-flash), and `models.json` has no `gpt-codex-spark` key. Rerunning the script leaves the token literal, so the `default` fallback chain at runtime contains the invalid model `openai-codex/__GPT_CODEX_SPARK__`, which is never resolvable and drops the intended spark candidate. It also breaks the existing contract in `spec/llm_update_spec.sh:188`, which asserts `fallbackChains.default == ["openai-codex/gpt-5.6-luna","openai-codex/gpt-5.3-codex-spark","openai-codex/gpt-5.6-sol"]`. Add a `gpt-codex-spark` entry to `models.json` (or an override in `llm-update.sh`) so the placeholder resolves to a concrete model, or revert the line to a concrete value, and update the spec accordingly.</comment>
<file context>
@@ -315,7 +315,7 @@ retry:
default:
- "openai-codex/gpt-5.6-luna"
- - "openai-codex/gpt-5.3-codex-spark"
+ - "openai-codex/__GPT_CODEX_SPARK__"
- "openai-codex/gpt-5.6-sol"
slow:
</file context>
937c81c to
ce34f3a
Compare
Pull request was closed
1 participant
Automated upgrade