Skip to content

fix(hermes): route through cliproxy only, drop broken fallback chain #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 3 commits into from
Aug 10, 2026
Merged

fix(hermes): route through cliproxy only, drop broken fallback chain #2335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33cb1eb
fix(hermes): route through cliproxy only, drop broken fallback chain
shunkakinoki Aug 10, 2026
1300f5d
fix(hermes): keep webhook platform + fallback chain in sync with open…
shunkakinoki Aug 10, 2026
7651719
fix(hermes): keep fallback chain + webhook platform, only fix default…
shunkakinoki Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/hermes/config.template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
model:
default: cliproxy/deepseek-v4-flash
base_url: https://cliproxy.shunkakinoki.com/v1
api_key: __CLIPROXY_API_KEY__

@indent-zero indent-zero Bot Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant credentials on the top-level model: block

providers.cliproxy at lines 5-9 already sets base_url/api_key/api_mode, and custom_providers at the tail sets them a third time. Because model.default uses the prefixed cliproxy/deepseek-v4-flash form, routing resolves through the registered provider without needing credentials here.

On main the analogous delegation: section uses base_url: ''/api_key: '' empty strings, suggesting per-section credentials are optional overrides rather than required. If these top-level fields are genuinely needed to work around a bug, add a comment explaining why; otherwise drop them (in both config.template.yaml and config.tpl.yaml) so there's one source of truth for the cliproxy endpoint/key.

Comment thread
coderabbitai[bot] marked this conversation as resolved.
providers:
cliproxy:
base_url: https://cliproxy.shunkakinoki.com/v1
Expand Down
8 changes: 8 additions & 0 deletions config/hermes/config.tpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
model:
default: cliproxy/__DEEPSEEK_FLASH__
base_url: https://cliproxy.shunkakinoki.com/v1
api_key: __CLIPROXY_API_KEY__
providers:
cliproxy:
base_url: https://cliproxy.shunkakinoki.com/v1
Expand Down Expand Up @@ -331,3 +333,9 @@ custom_providers:
base_url: https://cliproxy.shunkakinoki.com/v1
api_key: __CLIPROXY_API_KEY__
api_mode: chat_completions
platforms:
webhook:
enabled: true
extra:
port: 8644
secret: __WEBHOOK_SECRET__
Loading