fix(tokscale): expose crontab during activation - #2213
Conversation
|
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as a duplicate of #2212, which contains the same activation fix and is already merged. |
| ]) | ||
| "/usr/bin" | ||
| "/bin" | ||
| ]; |
There was a problem hiding this comment.
Latent: crontab isn't Nix-provided in activationPath. The new PATH exposes /run/wrappers/bin, /run/current-system/sw/bin, pkgs.coreutils, pkgs.gawk, /usr/bin, and /bin — but no Nix package here provides crontab. This works today because the host provides it (NixOS setuid wrapper when services.cron.enable = true, or /usr/bin/crontab on non-NixOS Linux). If a user runs home-manager switch on a NixOS host without cron enabled, activation still fails with the existing command -v crontab error from activate-cron.sh:9-12 (no regression). Consider either (a) adding pkgs.cronie (or similar) to activationPath via lib.makeBinPath so activation is self-contained, or (b) documenting the host cron requirement in the module. Either way, the current PR is safe — this is purely a note about the reachability boundary.
Summary
crontabis exposedValidation
nixfmt --check home-manager/services/tokscale/default.nixdotagents-syncfailure is unrelated and is already tracked by fix(ci): authenticate and prune external skill sync #2203Closes
shunkakinokisoftware-bb87Summary by cubic
Set an explicit NixOS-safe PATH during Home Manager activation so
crontabis found and cron setup doesn’t fail. Keeps the existing installer and schedule; resolvesshunkakinokisoftware-bb87.activationPathincluding/run/wrappers/bin,/run/current-system/sw/bin,lib.makeBinPathforcoreutilsandgawk, plus/usr/binand/bin.activate-cron.shviaenv PATH=$activationPathbeforebash, leavingcronCommandunchanged.Written for commit aa1fa3d. Summary will update on new commits.