Skip to content

fix(nix): restore Claude Desktop CI evaluation - #2128

Merged
shunkakinoki merged 1 commit into
mainfrom
codex/fix-claude-desktop-ci
Jul 19, 2026
Merged

fix(nix): restore Claude Desktop CI evaluation#2128
shunkakinoki merged 1 commit into
mainfrom
codex/fix-claude-desktop-ci

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • advance llm-agents.nix to a revision that exports Claude Desktop
  • retain the existing stdenv.isLinux && isDesktop package gate
  • keep the upstream overlays.default contract used by this repository

Root cause

PR #2114 referenced pkgs.llm-agents.claude-desktop, but flake.lock still pointed to a revision from the period when upstream had removed that package. Newer revisions after July 12 also remove overlays.default, so this selects the July 7 compatibility revision containing the repaired Claude Desktop package.

Validation

  • nix eval --impure --raw .#nixosConfigurations.matic.pkgs.llm-agents.claude-desktop.drvPath -> claude-desktop-1.18286.0.drv
  • make nix-format-check
  • nix flake check --system x86_64-linux --no-build advances past the original missing attribute; Linux-only Docker IFD cannot execute on the local aarch64-darwin host and is left to GitHub Actions

Summary by cubic

Restores Claude Desktop evaluation in Nix CI by pinning llm-agents.nix to a revision that exports llm-agents.claude-desktop. Keeps the stdenv.isLinux && isDesktop gate and the upstream overlays.default contract.

Written for commit c9e711f. Summary will update on new commits.

Review in cubic

@indent-zero

indent-zero Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor
PR Summary

Restores nix flake check (specifically pkgs.llm-agents.claude-desktop on Linux desktops) by advancing the llm-agents.nix lock entry to the 2026-07-07 revision that both exports overlays.default and ships the repaired Claude Desktop package. This unblocks the evaluation that PR #2114 introduced when it added pkgs.llm-agents.claude-desktop while the lock still pointed to an upstream rev that had temporarily removed that attribute.

  • Bumps llm-agents in flake.lock from 8d041d85… (2026-06-29) to 23c2c204… (2026-07-07) — an upstream commit that adds libXcursor/virtiofsd libs and switches Claude Desktop to the in-tree formatelf autoPatchelf hook.
  • Transitively bumps bun2nix (2026-05-10 → 2026-06-29) and flake-parts (2026-05-13 → 2026-07-01) because both are follow-inputs of llm-agents.nix.
  • No changes to flake.nix, overlays, or the stdenv.isLinux && isDesktop package gate; the upstream overlays.default contract used at overlays/default.nix:44 is preserved.

Issues

1 potential issue found:

  • The llm-agents input in flake.nix is not rev-pinned in its URL, so the next nix flake update or renovate lock-file-maintenance PR can move it past the July 12 window called out in this PR's description and silently re-drop claude-desktop (or overlays.default), reintroducing the exact failure being fixed here. Consider pinning to github:numtide/llm-agents.nix/23c2c2049b21ff57bc4c159ccb1e0eddb1d4238b following the same pattern used for noctalia-shell at flake.nix:69.</issue_text>
    latent → Autofix

CI Checks

Waiting for CI checks...


⚡ Autofix All Issues

@cursor

cursor Bot commented Jul 19, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@mesa-dot-dev

mesa-dot-dev Bot commented Jul 19, 2026

Copy link
Copy Markdown

You do not have enough credits to review this pull request. Please purchase more credits to continue.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: be112d18-0a49-4356-9b51-f9c75ec66fd4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-claude-desktop-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependency locks in flake.lock, specifically updating bun2nix, flake-parts, and llm-agents.nix to their newer revisions. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@mesa-dot-dev

mesa-dot-dev Bot commented Jul 19, 2026

Copy link
Copy Markdown

Mesa Description

TL;DR

Restores Claude Desktop in CI by advancing the llm-agents flake input to a July 7 compatibility revision.

What changed?

  • flake.lock: Advanced the llm-agents input to the July 7 compatibility revision, which exports the restored claude-desktop package and retains the overlays.default contract.
  • Nix Configuration: Retained the existing stdenv.isLinux && isDesktop package gate to control package evaluation.

Description generated by Mesa. Update settings

@shunkakinoki
shunkakinoki merged commit 0147b95 into main Jul 19, 2026
29 of 30 checks passed
@shunkakinoki
shunkakinoki deleted the codex/fix-claude-desktop-ci branch July 19, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant