Skip to content

chore(matic): Remove Falcon, Kolide, and install ISO - #2082

Merged
shunkakinoki merged 1 commit into
mainfrom
chore/matic-remove-falcon-iso
Jul 16, 2026
Merged

chore(matic): Remove Falcon, Kolide, and install ISO#2082
shunkakinoki merged 1 commit into
mainfrom
chore/matic-remove-falcon-iso

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove CrowdStrike Falcon sensor packaging, init, and optional module import from named-hosts/matic
  • Remove Kolide launcher module and its Falcon compliance shim
  • Remove maticIso flake configuration and eval check (iso.nix)
  • Drop the Falcon-only Linux 6.18 kernel pin so matic tracks the default kernel

Changes

  • Delete named-hosts/matic/falcon*, kolide.nix, iso.nix
  • Simplify named-hosts/matic/default.nix (no falcon gate / kolide import / kernel pin)
  • Drop maticIso from flake.nix and eval-nixos-matic-iso from tests/eval.nix
  • Update coverage specs for removed falcon-init.sh

Testing

  • nix-instantiate --parse named-hosts/matic/default.nix
  • Grep confirms no remaining falcon/kolide/maticIso references

Host cleanup (after switch)

On matic, after make build HOST=matic && make switch HOST=matic (or boot+reboot):

sudo systemctl stop falcon-sensor.service kolide-launcher.service 2>/dev/null || true
sudo rm -f /etc/nixos/falcon-sensor.deb /etc/falcon-sensor.env
sudo chattr -i -R /opt/CrowdStrike 2>/dev/null || true
sudo rm -rf /opt/CrowdStrike /etc/kolide-k2

Generated with [Grok Build] by [Grok]


Summary by cubic

Remove CrowdStrike Falcon and Kolide from the matic host and delete the maticIso build. matic now tracks the default kernel with a simpler host config.

  • Refactors

    • Removed Falcon packaging/init, Kolide module, and ISO module; deleted related tests and coverage.
    • Dropped optional Falcon import and the Linux 6.18 kernel pin; updated flake.nix and eval to remove maticIso.
    • Simplified named-hosts/matic/default.nix; kept nix-ld enabled.
  • Migration

    • After switching, stop falcon-sensor and kolide-launcher and remove /opt/CrowdStrike, /etc/kolide-k2, and any Falcon artifacts under /etc (e.g., falcon-sensor.deb, falcon-sensor.env).

Written for commit cf23c6b. Summary will update on new commits.

Review in cubic

Drop CrowdStrike Falcon sensor packaging and the optional falcon.nix
import gate, Kolide launcher, and maticIso flake/eval targets. Also
remove the Falcon-only 6.18 kernel pin so matic uses the default kernel.
@indent-zero

indent-zero Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor
PR Summary

Removes CrowdStrike Falcon, Kolide, and matic install-ISO scaffolding from the matic NixOS host to shrink the maintained surface and revert to the default kernel now that the 6.18 Falcon-compat pin is no longer needed. Callers that referenced the deleted flake/eval targets (maticIso) or shell script (falcon-init.sh) were updated in the same commit, though one auto-generated Make target still points at the removed flake attribute.

  • Deletes named-hosts/matic/falcon.nix, falcon/default.nix, falcon-init.sh, kolide.nix, and iso.nix
  • Drops falconDebExists gate, ./kolide.nix import, linuxPackages_6_18 kernel pin, and the CrowdStrike/Kolide nix-ld comment from named-hosts/matic/default.nix
  • Removes the maticIso output from flake.nix and the matching eval-nixos-matic-iso check from tests/eval.nix
  • Deletes spec/falcon_init_spec.sh and its entries in spec/coverage_spec.sh so the covered-scripts list stays in sync with git ls-files

Issues

1 potential issue found:

  • make build-matic-iso is broken: Makefile still lists matic in ISO_NAMED_HOSTS (line 40), so the auto-generated target invokes nix build .#nixosConfigurations.maticIso..., which fails with an "attribute missing" error now that the maticIso flake output was removed. Drop matic from ISO_NAMED_HOSTS (e.g. $(filter viper,$(NAMED_HOSTS))). → Autofix

CI Checks

Waiting for CI checks...


⚡ Autofix All Issues

@cursor

cursor Bot commented Jul 16, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c8ea4d56-65f3-4af4-9ed4-e29e0f8c4f5e

📥 Commits

Reviewing files that changed from the base of the PR and between eacbdf6 and cf23c6b.

📒 Files selected for processing (10)
  • flake.nix
  • named-hosts/matic/default.nix
  • named-hosts/matic/falcon-init.sh
  • named-hosts/matic/falcon.nix
  • named-hosts/matic/falcon/default.nix
  • named-hosts/matic/iso.nix
  • named-hosts/matic/kolide.nix
  • spec/coverage_spec.sh
  • spec/falcon_init_spec.sh
  • tests/eval.nix
💤 Files with no reviewable changes (9)
  • named-hosts/matic/falcon-init.sh
  • named-hosts/matic/iso.nix
  • spec/falcon_init_spec.sh
  • named-hosts/matic/falcon/default.nix
  • named-hosts/matic/kolide.nix
  • named-hosts/matic/falcon.nix
  • tests/eval.nix
  • flake.nix
  • spec/coverage_spec.sh

📝 Walkthrough

Summary by CodeRabbit

  • Removed Features
    • Removed the Matic ISO configuration and related build/evaluation checks.
    • Removed CrowdStrike Falcon sensor setup and packaging.
    • Removed Kolide Launcher configuration from the Matic system.
    • Matic no longer pins the kernel to version 6.18.
  • Tests
    • Removed tests covering the retired Falcon initialization script.

Walkthrough

The Matic configuration no longer includes Falcon or Kolide integration, pins a kernel version, or exports and evaluates a Matic ISO. Associated Falcon initialization files, packaging, modules, and coverage tests were removed.

Changes

Matic integration cleanup

Layer / File(s) Summary
Remove Falcon and Kolide configuration
named-hosts/matic/default.nix, named-hosts/matic/falcon.nix, named-hosts/matic/falcon-init.sh, named-hosts/matic/falcon/*, named-hosts/matic/kolide.nix
Falcon and Kolide modules, packaging, initialization, and the Matic kernel pin are removed.
Update shell coverage checks
spec/coverage_spec.sh, spec/falcon_init_spec.sh
Coverage references and tests for the deleted Falcon initializer are removed.

Matic ISO cleanup

Layer / File(s) Summary
Remove ISO configuration and checks
flake.nix, named-hosts/matic/iso.nix, tests/eval.nix
The maticIso flake output, ISO expression, and eval-nixos-matic-iso check are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: bug

Poem

I’m a rabbit hopping through the Nix,
Trimming Falcon from the config mix.
Kolide hops away, the ISO too,
Kernel pins vanish from view.
Clean flakes sparkle—carrot bliss!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing Falcon, Kolide, and the matic ISO configuration.
Description check ✅ Passed The description is directly aligned with the files changed and the stated cleanup goals.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/matic-remove-falcon-iso

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the CrowdStrike Falcon sensor and Kolide launcher configurations, scripts, packages, and associated tests from the matic host configuration. It also removes the matic ISO bootstrap configuration (iso.nix) and its evaluation checks. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@mesa-dot-dev

mesa-dot-dev Bot commented Jul 16, 2026

Copy link
Copy Markdown

Mesa Description

TL;DR

Removed CrowdStrike Falcon sensor, Kolide launcher, and custom installation ISO configurations from the matic host, aligning it with default system kernels and configurations.

What changed?

  • named-hosts/matic/default.nix: Cleaned up to remove Falcon gates, Kolide imports, and the Linux 6.18 kernel pin.
  • named-hosts/matic/falcon*: Deleted Falcon sensor packaging, environment configs, and initialization scripts.
  • named-hosts/matic/kolide.nix: Removed Kolide launcher module and its Falcon compliance shim.
  • named-hosts/matic/iso.nix: Deleted the custom installation ISO configuration.
  • flake.nix: Dropped the maticIso target.
  • tests/eval.nix: Removed the eval-nixos-matic-iso check.
  • Coverage specs: Updated to reflect the removal of falcon-init.sh.

Host cleanup (after switch)

On matic, after make build HOST=matic && make switch HOST=matic (or boot+reboot):

sudo systemctl stop falcon-sensor.service kolide-launcher.service 2>/dev/null || true
sudo rm -f /etc/nixos/falcon-sensor.deb /etc/falcon-sensor.env
sudo chattr -i -R /opt/CrowdStrike 2>/dev/null || true
sudo rm -rf /opt/CrowdStrike /etc/kolide-k2

Description generated by Mesa. Update settings

@mesa-dot-dev mesa-dot-dev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of eacbdf6...cf23c6b

Analysis

• Security posture materially changes with EDR and device trust removal, but the PR lacks documentation of the security rationale or compensating controls—this creates an implicit security decision that may not be visible to future maintainers or auditors

• Dynamic linking infrastructure (nix-ld) remains enabled despite its primary use case being removed—clarify whether legitimate uses justify its retention or if it should also be decommissioned

• No safeguards exist to prevent accidental reintroduction of removed modules during future refactoring—consider adding assertions that matic explicitly does not import the deleted security modules

• Kernel unpinning removes explicit documentation of why the pin existed, which may cause future maintainers to wonder about the historical constraint—add a brief comment explaining the pin was Falcon-specific

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

0 files reviewed | 0 comments | Edit Agent SettingsRead Docs

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Re-trigger cubic

@shunkakinoki
shunkakinoki merged commit 300ad53 into main Jul 16, 2026
40 of 41 checks passed
@shunkakinoki
shunkakinoki deleted the chore/matic-remove-falcon-iso branch July 16, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant