Skip to content

fix(npm-globals): skip .exe bins in postinstall check, remove @sourcegraph/amp #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 2 commits into from
Jul 11, 2026
Merged

fix(npm-globals): skip .exe bins in postinstall check, remove @sourcegraph/amp #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
319bbfe
fix(npm-globals): skip .exe bins in postinstall check, remove @source…
shunkakinoki Jul 11, 2026
6902173
chore(deps): add @ampcode/cli to npm globals
shunkakinoki Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion home-manager/modules/npm-globals/install-npm-globals.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ run_postinstall_if_needed() {
local has_native=false
for f in "$bin_dir"/*; do
[ -f "$f" ] || continue
case "$f" in *.js | *.cjs | *.mjs) continue ;; esac
case "$f" in *.js | *.cjs | *.mjs | *.exe) continue ;; esac

@gemini-code-assist gemini-code-assist Bot Jul 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In addition to .exe files, many npm packages also include other Windows-specific wrapper scripts such as .cmd, .bat, and .ps1 in their bin directory. If any of these are present, they will be incorrectly detected as native macOS/Linux binaries, causing the postinstall script to be skipped. It is safer to skip all common Windows executable/script extensions.

Suggested change
case "$f" in *.js | *.cjs | *.mjs | *.exe) continue ;; esac
case "$f" in *.js | *.cjs | *.mjs | *.exe | *.cmd | *.bat | *.ps1) continue ;; esac

has_native=true
break
done
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"packageManager": "bun@1.3.14",
"dependencies": {
"@0xsequence/codegenie": "^0.4.1",
"@ampcode/cli": "^0.0.1783729003-g78d5e5",
"@anthropic-ai/claude-code": "^2.1.205",
"@augmentcode/auggie": "^0.32.0",
"@biomejs/biome": "^2.5.3",
Expand All @@ -38,7 +39,6 @@
"@redwoodjs/agent-ci": "^0.16.2",
"@schpet/linear-cli": "^2.0.0",
"@sentry/cli": "^3.6.0",
"@sourcegraph/amp": "^0.0.1783629102-g8185a2",
"@steipete/bird": "^0.8.0",
"@tobilu/qmd": "^2.5.3",
"@traces-sh/traces": "^0.6.9",
Expand Down Expand Up @@ -97,6 +97,7 @@
},
"trustedDependencies": [
"@0xsequence/codegenie",
"@ampcode/cli",
"@anthropic-ai/claude-code",
"@augmentcode/auggie",
"@biomejs/biome",
Expand All @@ -123,7 +124,6 @@
"@redwoodjs/agent-ci",
"@schpet/linear-cli",
"@sentry/cli",
"@sourcegraph/amp",
"@steipete/bird",
"@tobilu/qmd",
"@traces-sh/traces",
Expand Down
Loading