Skip to content

fix(spec): format npm_globals_spec.sh to satisfy treefmt check - #2028

Merged
shunkakinoki merged 1 commit into
mainfrom
claude/elastic-kalam-5d33fb
Jul 8, 2026
Merged

fix(spec): format npm_globals_spec.sh to satisfy treefmt check#2028
shunkakinoki merged 1 commit into
mainfrom
claude/elastic-kalam-5d33fb

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Changes

  • Flatten ShellSpec DSL indentation in spec/npm_globals_spec.sh to match shfmt output

Technical Details

Testing

  • nix fmt -- --clear-cache --fail-on-change passes (0 changed)
  • shellspec spec/npm_globals_spec.sh: 61 examples, 0 failures

Generated with Claude Code by Fable 5


Summary by cubic

Formats spec/npm_globals_spec.sh to match shfmt output so checks.x86_64-linux.treefmt passes and Nix CI jobs run again.

  • Bug Fixes
    • Flattened ShellSpec blocks in bun npm shim purge and postinstall recovery to match shfmt.
    • Unblocks Nix workflows gated by --fail-on-change (nix-format, nix-test, nix-flake, nix-check).
    • No logic changes; verified with nix fmt -- --clear-cache --fail-on-change and shellspec (61 examples, 0 failures).

Written for commit baf8105. Summary will update on new commits.

Review in cubic

@indent-zero

indent-zero Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor
PR Summary

Reformats spec/npm_globals_spec.sh so it matches the repo's shell formatter (shfmt -i 2 -s, wired through treefmt.toml), unblocking the CI treefmt check. Only whitespace changes — no functional impact on the Shellspec suite, which is keyword-driven and indentation-insensitive.

Issues

No issues found.

CI Checks

Waiting for CI checks...

@cursor

cursor Bot commented Jul 8, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@shunkakinoki, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 58196e66-5bf0-458e-9835-546e58cc119b

📥 Commits

Reviewing files that changed from the base of the PR and between 7d9f90f and baf8105.

📒 Files selected for processing (1)
  • spec/npm_globals_spec.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/elastic-kalam-5d33fb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shunkakinoki shunkakinoki added the bug Indicates an unexpected problem or unintended behavior. label Jul 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies spec/npm_globals_spec.sh by removing the indentation (leading spaces) for the test cases within the 'bun npm shim purge' and 'postinstall recovery' describe blocks. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@mesa-dot-dev

mesa-dot-dev Bot commented Jul 8, 2026

Copy link
Copy Markdown

Mesa Description

TL;DR

Flattened ShellSpec DSL indentation in spec/npm_globals_spec.sh to satisfy the treefmt check and fix broken Nix workflow jobs on the main branch.

What changed?

  • spec/npm_globals_spec.sh: Flattened indentation of the ShellSpec DSL for the bun npm shim purge and postinstall recovery blocks to match the output expected by shfmt (via treefmt).

Description generated by Mesa. Update settings

@mesa-dot-dev mesa-dot-dev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 7d9f90f...baf8105

Analysis

This PR is a formatting-only change with minimal architectural risk. However, it reveals systemic pipeline fragility: the CI/CD relies on strict formatting gates via treefmt that interact poorly with DSL-heavy shell syntax (ShellSpec), creating brittleness without sufficient contributor guidance. The pipeline lacks preventive controls (pre-commit hooks, scoped formatter configs, documented indentation conventions for DSLs) to catch these issues before they block all workflow jobs. While functionally safe to merge, the underlying architecture should be hardened to prevent future formatter churn in DSL-sensitive files.

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

0 files reviewed | 0 comments | Edit Agent SettingsRead Docs

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@shunkakinoki
shunkakinoki merged commit f7e53ec into main Jul 8, 2026
36 of 37 checks passed
@shunkakinoki
shunkakinoki deleted the claude/elastic-kalam-5d33fb branch July 8, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Indicates an unexpected problem or unintended behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant