Skip to content

fix(fish): add ~/.railway/bin to PATH - #2020

Closed
shunkakinoki wants to merge 1 commit into
mainfrom
fix/add-railway-bin-to-path
Closed

fix(fish): add ~/.railway/bin to PATH#2020
shunkakinoki wants to merge 1 commit into
mainfrom
fix/add-railway-bin-to-path

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Summary by cubic

Add ~/.railway/bin to PATH in fish Home Manager config so the Railway CLI is available in all shells.
Sets it early in PATH and adds fish_add_path on both Linux and macOS to avoid “command not found” after install.

Written for commit 52874aa. Summary will update on new commits.

Review in cubic

@indent-zero

indent-zero Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor
PR Summary

Adds ~/.railway/bin to the fish shell PATH so the Railway CLI (installed via railway.com/install.sh to ~/.railway/bin/railway) is discoverable from fish sessions. The change is applied in all three fish init blocks to cover non-interactive, login, and interactive shells uniformly.

  • home-manager/programs/fish/default.nix: prepend $HOME/.railway/bin in shellInit's set -gx PATH line.
  • home-manager/programs/fish/default.nix: add fish_add_path -p -m ~/.railway/bin in loginShellInit at a low-priority slot.
  • home-manager/programs/fish/default.nix: mirror the same fish_add_path entry in interactiveShellInit for parity.

Issues

1 potential issue found:

  • zsh (home-manager/programs/zsh/default.nix) and bash (home-manager/programs/bash/bash_env.sh, default.nix) PATH blocks don't include ~/.railway/bin, so railway will be missing there; primary shell is fish so this is a parity nit, not a bug. → Autofix

CI Checks

Waiting for CI checks...


⚡ Autofix All Issues

@cursor

cursor Bot commented Jul 7, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d60c35b7-d7eb-4096-8865-f5f833d72003

📥 Commits

Reviewing files that changed from the base of the PR and between b4630dc and 52874aa.

📒 Files selected for processing (1)
  • home-manager/programs/fish/default.nix

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Fish shell sessions now include ~/.railway/bin in the PATH, making Railway commands available more consistently.
    • PATH setup is applied for both login and interactive Fish shells, improving access across different terminal start modes.

Walkthrough

The Fish shell configuration adds ~/.railway/bin to PATH: prepended in the shellInit PATH export, and added via fish_add_path -p -m in both loginShellInit and interactiveShellInit hooks.

Changes

Fish PATH configuration

Layer / File(s) Summary
Add Railway bin directory to Fish PATH
home-manager/programs/fish/default.nix
Prepends ~/.railway/bin in shellInit's PATH export and adds it via fish_add_path -p -m in both loginShellInit and interactiveShellInit.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit hops with railway cheer,
New bin path now sitting near,
Fish shell whispers, "PATH's complete,"
Login or interactive, both a treat,
Hop hop hooray, the tracks are set! 🐰🚂

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/add-railway-bin-to-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the ~/.railway/bin directory to the PATH configuration in home-manager/programs/fish/default.nix across multiple blocks to ensure Railway binaries are available in the Fish shell environment. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

fish_add_path -p -m /nix/var/nix/profiles/default/bin
fish_add_path -p -m ~/.nix-profile/bin
fish_add_path -p -m /etc/profiles/per-user/${config.home.username}/bin
fish_add_path -p -m ~/.railway/bin

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parity nit: ~/.railway/bin is only being added to fish. The zsh (home-manager/programs/zsh/default.nix:35 and the initContent PATH stack) and bash (home-manager/programs/bash/bash_env.sh, home-manager/programs/bash/default.nix) configs still don't include it, so invoking railway from those shells will fail. Since hosts/nixos/default.nix:55 sets shell = pkgs.fish; this is likely intentional scope — flagging in case you want the other shells kept in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant