fix(xremap): use globalRemap for code editors instead of terminalClipboardRemap - #2017
Conversation
…boardRemap terminalClipboardRemap remapped Ctrl+C -> Ctrl+Shift+C and Framework+C/V -> Ctrl+Shift+C/V in Cursor/VS Code. This broke copy/paste since code editors use Ctrl+C/V natively (not the terminal Ctrl+Shift+C/V convention). The integrated terminal handles its own clipboard shortcuts internally. Switch code editors to globalRemap so Framework+C/V correctly becomes Ctrl+C/V and bare Ctrl+C/V passes through unmodified.
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughChanges the xremap keymap configuration for the "Framework Command (Code Editors)" entry (Cursor/VS Code), switching the remap target from ChangesXremap Keymap Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the xremap configuration for code editors (Cursor/VS Code) in home-manager/modules/xremap/default.nix. It changes the remap behavior from terminalClipboardRemap to globalRemap to allow standard Ctrl+C/V shortcuts for copy and paste, noting that the integrated terminal manages its own clipboard shortcuts. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| name = "Framework Command (Code Editors)"; | ||
| application.only = codeEditorAppIds; | ||
| remap = terminalClipboardRemap; | ||
| remap = globalRemap; |
There was a problem hiding this comment.
Redundant with the Global fallback: globalRemap here produces the exact same output as the unfiltered Framework Command (Global) block at line 139, so this entry no longer changes behavior for Cursor/VS Code — the Global block would catch them anyway. Not a bug (the fix is correct), but the block currently only serves as documentation of intent. Consider either dropping it or adding a comment that it's intentionally kept as a hook for future editor-specific tweaks.
Summary
terminalClipboardRemap, which remappedCtrl+C->Ctrl+Shift+CandFramework+C/V->Ctrl+Shift+C/VCtrl+C/Vnatively (theCtrl+Shift+C/Vconvention is only for terminal emulators)globalRemapso Framework+C/V correctly becomes Ctrl+C/V and bare Ctrl+C/V passes through unmodifiedTest plan
sudo nixos-rebuild switch --flake .)Summary by cubic
Fixes copy/paste in Cursor and VS Code by switching code editors from
terminalClipboardRemaptoglobalRemapinxremap.Framework+C/Vnow maps toCtrl+C/Vand bareCtrl+C/Vpasses through; terminal emulators keep theirCtrl+Shift+C/Vbehavior.Written for commit cef9f8f. Summary will update on new commits.