fix(shell): update test to match bun PATH reorder from #2008

[shunkakinoki]

Summary

• PR fix(fish): prevent hoisted bun npm stub from shadowing real native bun #2008 reordered the fish shellInit PATH to put ~/.bun/bin before ~/.bun/install/global/node_modules/.bin so the real native bun binary always wins over hoisted npm stubs
• The shellspec test at spec/atuin_history_spec.sh:147 still expected the old order, causing the Shell CI workflow to fail on every push to main
• Updated the grep pattern in the test to match the current fish config

Test plan

• Shell CI workflow passes with the corrected test assertion

---

Summary by cubic

Update shellspec to match the fish PATH reorder introduced in #2008, placing ~/.bun/bin before ~/.bun/install/global/node_modules/.bin so the native bun binary takes precedence. Fixes the Shell CI failure by aligning the test with the current fish config.

^{Written for commit 6ed1da3. Summary will update on new commits.}

[indent-zero]

PR Summary

Test-only follow-up to merged PR #2008, which reordered the fish set -gx PATH line so $HOME/.bun/bin precedes $HOME/.bun/install/global/node_modules/.bin (ensuring the real native bun binary is never shadowed by a hoisted npm stub). The atuin_history_spec.sh grep assertion still encoded the pre-#2008 ordering and was failing against main; this PR updates the literal pattern to match, restoring green CI without any behavioral change.

• Updated the grep -F pattern in spec/atuin_history_spec.sh (line 147) so $HOME/.bun/bin comes before $HOME/.bun/install/global/node_modules/.bin, matching line 14 of home-manager/programs/fish/default.nix.

Issues

No issues found.

CI Checks

Waiting for CI checks...

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fc860358-7a5a-4057-8350-4fabd33c720c

📥 Commits

Reviewing files that changed from the base of the PR and between c6039c1 and 6ed1da3.

📒 Files selected for processing (1)

• spec/atuin_history_spec.sh

---

📝 Walkthrough

Summary by CodeRabbit

• Tests
  • Updated the shell configuration test to match the current order of PATH entries in Fish shell startup settings.

Walkthrough

Updated a test assertion in spec/atuin_history_spec.sh to expect a reordered PATH: $HOME/.bun/bin now appears before $HOME/.bun/install/global/node_modules/.bin in the fish shellInit non-interactive alias config test.

Changes

Test Assertion Update

Layer / File(s)	Summary
Fish PATH ordering assertion spec/atuin_history_spec.sh	Swapped expected order of two bun-related PATH entries in the grep -F 'set -gx PATH ...' assertion.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• shunkakinoki/dotfiles#1020: Updates fish PATH ordering logic in home-manager fish config that this test assertion aligns with.
• shunkakinoki/dotfiles#1887: Changes fish PATH ordering for bun's global node_modules/.bin that this assertion reflects.

Poem

A hop, a skip, a PATH rearranged,
Bun's bin now first, the order's changed,
One little line in a spec so small,
This bunny thumps approval for all! 🐇✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the test update for the bun PATH reorder and is specific to the change.
Description check	✅ Passed	The description directly explains the shellspec test update and its relation to the PATH reorder change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/shell-test-bun-path-order

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request updates a test case in spec/atuin_history_spec.sh to adjust the expected order of paths in the fish shell configuration, specifically placing $HOME/.bun/bin before $HOME/.bun/install/global/node_modules/.bin in the PATH assertion. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.