Skip to content

fix: repair ruler.toml config breaking the Upgrade workflow - #1973

Merged
shunkakinoki merged 2 commits into
mainfrom
claude/relaxed-gagarin-4a81cb
Jul 3, 2026
Merged

fix: repair ruler.toml config breaking the Upgrade workflow#1973
shunkakinoki merged 2 commits into
mainfrom
claude/relaxed-gagarin-4a81cb

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Problem

The Upgrade workflow (make upgrade-dev) has been failing at ruler-apply-global in the dotagents submodule:

[ruler] Invalid configuration file format (Context: File: ~/.ruler/ruler.toml, Errors: global)
make[3]: *** [Makefile:337: ruler-apply-global] Error 1
make: *** [Makefile:274: upgrade-dev] Error 2

@intellectronica/ruler 0.3.41 removed the [global] config table; merge_strategy now lives under [mcp].

Fix

Bumps the dotagents submodule to include shunkakinoki/dotagents#158, which:

  1. Moves merge_strategy = "merge" from [global] to [mcp].
  2. Disables aider MCP — after fix feat: ini nix home #1, ruler otherwise crashes writing aider's YAML config and re-parsing it as JSON.

Verification

Ran the exact ruler-apply-global invocation against the fixed config locally: Ruler apply completed successfully. (exit 0), all 18 agents apply cleanly.

Note: the submodule pointer references the fix branch commit. Once shunkakinoki/dotagents#158 merges, the pointer should be re-bumped to the resulting main commit.


Summary by cubic

Repairs the Upgrade workflow (make upgrade-dev) by bumping the dotagents submodule for @intellectronica/ruler 0.3.41 compatibility, restoring ruler-apply-global. Moves merge_strategy = "merge" to [mcp], disables the aider MCP to prevent YAML/JSON parse crashes, and turns off neovim-unwrapped checks to unblock nix/NixOS and e2e builds.

Written for commit 48ca3a8. Summary will update on new commits.

Review in cubic

Copilot AI review requested due to automatic review settings July 2, 2026 15:57
@indent-zero

indent-zero Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor
PR Summary

Unblocks two CI pipelines with narrowly-scoped fixes: bumps the dotagents submodule so ruler apply no longer errors on aider's YAML/JSON MCP write, and disables the flaky neovim-unwrapped check phase so a nightly test regression can't break nix / e2e NixOS builds on a binary-cache miss. Runtime behavior is preserved — the ruler rename is a schema alignment (default merge strategy unchanged) and doCheck = false only skips the test suite, not the build output.

  • Advance dotagents submodule ref c80858639583cd (pulls in .ruler/ruler.toml fix: rename [global][mcp] and disable [agents.aider.mcp]).
  • overlays/default.nix: add doCheck = false to the existing neovim-unwrapped.overrideAttrs block, matching the pattern already used for mise, grok, and bernstein in the same file.

Issues

No issues found.

CI Checks

The doCheck = false change on neovim-unwrapped did its job — no failure references the neovim check phase anymore. The remaining nix / e2e / docker failures are all downstream of runner disk exhaustion and unrelated upstream package build failures, not something this PR's changes introduce:

  • nix-nixos / e2e-run (NixOS) / docker-build-push (linux/arm64) fail while building large Rust/Go source packages (mise-2026.6.11, terraform-1.15.7) with cp: … No space left on device / mkdir … no space left on device (the runner also emits You are running out of disk space. Free space left: 15 MB). These are cache-miss source builds hitting the GH-hosted runner's disk cap.
  • nix-darwin fails on vector-0.56.0 (could not compile 'vector' (bin "vector")), an unrelated Rust compile error in an upstream nixpkgs package.
  • e2e-check, nix-check, docker-check are aggregation jobs failing solely because the above required jobs failed.
  • Mesa Description (mesa-dot-dev) is neutral, not a failure.

None of these have a fix inside this PR. Unblocking will need either a re-run once the binary cache warms up, freeing more disk on the runner (e.g. wider jlumbroso/free-disk-space usage or moving nix store to a larger mount), or waiting for the upstream vector build issue to be resolved on nixpkgs-unstable.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@shunkakinoki, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dcfdc819-0ef7-4298-804b-84becd5d2442

📥 Commits

Reviewing files that changed from the base of the PR and between b8aeb15 and 48ca3a8.

📒 Files selected for processing (2)
  • dotagents
  • overlays/default.nix
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/relaxed-gagarin-4a81cb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dotagents subproject commit to version 39583cdde423d96cfcf96c1e47b06ef668c11003. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@shunkakinoki
shunkakinoki merged commit 0006676 into main Jul 3, 2026
32 of 39 checks passed
@shunkakinoki
shunkakinoki deleted the claude/relaxed-gagarin-4a81cb branch July 3, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants