chore: update dependencies and add shellcheck directives - #1755
Conversation
Update multiple JavaScript/TypeScript packages via bun and Python dependencies via uv. Key updates: - @anthropic-ai/claude-code: 2.1.138 -> 2.1.139 - @github/copilot: 1.0.44 -> 1.0.45 - @oh-my-pi/pi-*: 14.9.3 -> 14.9.5 - chrome-devtools-mcp: 0.25.0 -> 0.26.0 - playwright-chromium: 1.59.1 -> 1.60.0 - oxlint: 1.63.0 -> 1.64.0 - vllm (Python): 0.20.0 -> 0.20.1 Also: - Add last_pull to beads .gitignore - Add shellcheck directives to activate_roborev_spec.sh Co-Authored-By: Claude 4.7 <noreply@example.com>
|
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates package dependencies across Node.js and Python environments, adds a runtime file to gitignore, and applies ShellCheck linting directives to a test script. All changes are maintenance-focused without functional code modifications. ChangesDependency and Configuration Maintenance
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on dependency management, updating numerous packages across package.json, bun.lock, flake.lock, and pyproject.toml. Key updates include Claude Code, Copilot, OMP, Oxlint, and Playwright. It also introduces minor configuration changes, such as adding last_pull to .gitignore and ShellCheck directives to test scripts. Feedback focuses on the security implications of adding deepsec to trustedDependencies in the lockfile and a version mismatch between Playwright components that could cause runtime or CI issues.
| "@ccusage/codex", | ||
| "openclaw", | ||
| "clawdhub", | ||
| "deepsec", |
There was a problem hiding this comment.
Adding deepsec to trustedDependencies allows the package to execute arbitrary lifecycle scripts (like postinstall) during installation. This is a security-sensitive configuration change that was not explicitly mentioned in the PR description, especially since deepsec was already a dependency without this privilege. Unless deepsec strictly requires these scripts to function (e.g., for compiling native bindings), it is recommended to keep the trusted list as minimal as possible to reduce the attack surface. Additionally, ensure this change is synchronized with the trustedDependencies field in package.json.
| "playwright-chromium": ["playwright-chromium@1.59.1", "", { "dependencies": { "playwright-core": "1.59.1" }, "bin": { "playwright": "cli.js" } }, "sha512-aTsPenkxsr9np4vIHuMEND6comqepVvzbL0MwkozFNliwGZjTqrBUQ7TF6Ay1ZIU/e7rcUpGsCTUG+nqwxG2Xw=="], | ||
| "playwright-chromium": ["playwright-chromium@1.60.0", "", { "dependencies": { "playwright-core": "1.60.0" }, "bin": { "playwright": "cli.js" } }, "sha512-xxz9pc2HIxQW/Qg9ijG2fZOHRT//KhLo0KfvJRa45YYRrcA7ZONoilgJR40SW5pmecb6HkuROaeViXoCaXTZyQ=="], | ||
|
|
||
| "playwright-core": ["playwright-core@1.59.1", "", { "bin": { "playwright-core": "cli.js" } }, "sha512-HBV/RJg81z5BiiZ9yPzIiClYV/QMsDCKUyogwH9p3MCP6IYjUFu/MActgYAvK0oWyV9NlwM3GLBjADyWgydVyg=="], |
There was a problem hiding this comment.
The top-level playwright-core version (1.59.1) is out of sync with the version required by playwright-chromium (1.60.0). Playwright requires the library and its core driver to have matching versions to ensure compatibility with browser binaries. Having multiple versions of playwright-core in the lockfile (as seen by the addition of the nested playwright-chromium/playwright-core entry in this PR) can lead to issues where the wrong browser version is used or installation fails in CI. Consider updating all Playwright-related dependencies to 1.60.0 to ensure a single, consistent version is used across the project.
Changes
last_pullto beads .gitignoreKey Dependency Updates
Testing
Generated with Claude Code by Claude 4.7
Summary by cubic
Updates JS/TS and Python dependencies to keep tooling current, and adds ShellCheck directives to the roborev activation spec. Also ignores the
last_pullstate file in.beads.Dependencies
@anthropic-ai/claude-code2.1.138 → 2.1.139@github/copilot1.0.44 → 1.0.45;@oh-my-pi/pi-*14.9.3 → 14.9.5playwright-chromium1.59.1 → 1.60.0;chrome-devtools-mcp0.25.0 → 0.26.0oxlint1.63.0 → 1.64.0;oxfmt0.48.0 → 0.49.0vllm0.20.0 → 0.20.1Refactors
# shellcheck shell=bashand disableSC2016inspec/activate_roborev_spec.sh.last_pullto.beads/.gitignore.Written for commit 5eb787a. Summary will update on new commits.