feat: add lean4 to nixpkgs packages - #1754
Conversation
|
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR adds Lean4 to Home Manager defaults, adds a conditional noctalia-shell restart Makefile target, switches Ghostty to use a local config file and ChangesRepository configuration updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesa DescriptionTL;DRAdds What changed?
Description generated by Mesa. Update settings |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
![indent-zero[bot]](https://avatars.githubusercontent.com/in/1426746?s=60&v=4){kind=small}
| # Framework 13 AI 300 embedded controller (I2C HID). keyd's `*` wildcard | ||
| # does not grab I2C HID consumer control devices, so the Framework key | ||
| # bypasses keyd unless this id is listed explicitly. | ||
| 32ac:0006 |
There was a problem hiding this comment.
Scope drift (nit): This keyd fix is unrelated to the PR's stated purpose (feat: add lean4 to nixpkgs packages). The change itself looks correct — keyd's * wildcard does not grab I2C HID consumer-control devices, so explicitly listing 32ac:0006 (Framework 13 AI 300 EC) is the right way to make the leftmeta/prog1/f13 → cmd_hyper remaps in [main] apply to the Framework key. But it would be easier to find this fix in git log if it lived in its own PR (or if PR #1754's title/description called it out).
| macos-titlebar-style = "tabs" | ||
| shell-integration = fish | ||
| command = __FISH_PATH__ --login | ||
| command = fish --login |
There was a problem hiding this comment.
Latent regression on macOS GUI launches: Previously config/ghostty/default.nix substituted __FISH_PATH__ with ${pkgs.fish}/bin/fish at build time, so this line was an absolute Nix store path. Now ghostty must resolve fish via PATH (execvp). On macOS, ghostty.app launched from Finder/Spotlight/dock inherits launchd's PATH, which by default contains only /usr/bin:/bin:/usr/sbin:/sbin plus entries in /etc/paths.d/*. The nix multi-user installer adds /nix/var/nix/profiles/default/bin there, but ~/.nix-profile/bin — where home-manager installs fish — is not on launchd's PATH unless the user manually ran launchctl setenv PATH .... Result: ghostty may fail to spawn the shell. On Linux desktop sessions this is fine because Hyprland/etc. inherit the user's session PATH. Either restore the ${pkgs.fish}/bin/fish substitution or document the launchd PATH requirement.
1 participant
Summary
lean4to the home-manager packages list in alphabetical orderTest plan
nixos-rebuild switchorhome-manager switchbuilds successfully with lean4 availableSummary by cubic
Add
lean4tohome-managerpackages and simplifyghosttyconfig to use a static file withfish --login. Fix input on Framework by havingkeydgrab32ac:0006, add asystemctl-noctalia-shellMakefile target (restart quickshell on matic), and suppressgtk4theme warnings.Written for commit 7120479. Summary will update on new commits.