fix(test): add roborev to shell coverage spec #1751
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,35 @@ | ||||||
| Describe 'home-manager/services/roborev/activate.sh' | ||||||
| SCRIPT="$PWD/home-manager/services/roborev/activate.sh" | ||||||
|
|
||||||
| It 'uses bash shebang' | ||||||
| When run bash -c "head -1 '$SCRIPT'" | ||||||
|
Contributor
There was a problem hiding this comment. The use of
Suggested change
|
||||||
| The output should include '#!/usr/bin/env bash' | ||||||
| End | ||||||
|
|
||||||
| It 'creates the data directory' | ||||||
| When run bash -c "grep 'mkdir' '$SCRIPT'" | ||||||
| The output should include 'mkdir -p' | ||||||
| End | ||||||
|
|
||||||
| It 'sets restrictive permissions on data directory' | ||||||
| When run bash -c "grep 'chmod' '$SCRIPT'" | ||||||
| The output should include 'chmod 700' | ||||||
| End | ||||||
| End | ||||||
|
|
||||||
| Describe 'home-manager/services/roborev/default.nix' | ||||||
| It 'enables on galactica and matic only' | ||||||
| When run bash -c "grep 'isGalactica || isMatic' '$PWD/home-manager/services/roborev/default.nix'" | ||||||
| The output should include 'isGalactica || isMatic' | ||||||
| End | ||||||
|
|
||||||
| It 'runs roborev daemon run' | ||||||
| When run bash -c "grep 'daemon' '$PWD/home-manager/services/roborev/default.nix'" | ||||||
| The output should include '"daemon"' | ||||||
| End | ||||||
|
|
||||||
| It 'passes data dir to activate script' | ||||||
| When run cat "$PWD/home-manager/services/roborev/default.nix" | ||||||
|
Contributor
There was a problem hiding this comment. Using
Suggested change
References
|
||||||
| The output should include '"${./activate.sh}" "${dataDir}"' | ||||||
| End | ||||||
| End | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing standard spec header: every other
spec/activate_*_spec.shfile (activate_qmd_spec.sh,activate_paperclip_openclaw_spec.sh,activate_k3s_spec.sh,activate_neovim_spec.sh,activate_tailscale_spec.sh) begins with:This file starts directly with
Describe, which is inconsistent with the established convention and may surface SC2016/SC2329 warnings on the inline single-quotedbash -c "grep '...' '$SCRIPT'"patterns when shellcheck runs over the spec directory.