Skip to content

fix(noctalia): preserve app icon colors #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
May 7, 2026
Merged

fix(noctalia): preserve app icon colors #1695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion config/noctalia/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ in
showNetworkStats = true;
showGpuTemp = true;
}
{ id = "ActiveWindow"; }
{
id = "ActiveWindow";
colorizeIcons = false;
}
{ id = "MediaMini"; }
];
widgets.center = [
Expand All @@ -81,6 +84,7 @@ in
widgets.right = [
{
id = "Tray";
colorizeIcons = false;
drawerEnabled = false;
}
Comment on lines 85 to 89

@coderabbitai coderabbitai Bot May 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Tray icon colorization is inverted relative to this PR objective.

Line 87 sets colorizeIcons = false, but this PR’s stated goal is to colorize tray icons while keeping the drawer disabled.

Suggested fix 
         widgets.right = [
           {
             id = "Tray";
-            colorizeIcons = false;
+            colorizeIcons = true;
             drawerEnabled = false;
           }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
id = "Tray";
colorizeIcons = false;
drawerEnabled = false;
}
{
id = "Tray";
colorizeIcons = true;
drawerEnabled = false;
}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@config/noctalia/default.nix` around lines 85 - 89, The Tray section currently
sets colorizeIcons = false while the PR intends to colorize tray icons; update
the Tray block (id = "Tray") to set colorizeIcons = true and keep drawerEnabled
= false so tray icons are colorized but the drawer remains disabled; locate the
Tray stanza containing id = "Tray", change colorizeIcons to true and leave
drawerEnabled unchanged.

{ id = "Bluetooth"; }
Expand Down
8 changes: 7 additions & 1 deletion spec/noctalia_bar_spec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,16 @@ The output should include 'Brightness DarkMode ControlCenter'
End

It 'shows tray items inline instead of hiding them in the drawer'
When run bash -c "awk '/id = \"Tray\";/{in_tray=1} in_tray && /drawerEnabled = false;/{print; exit}' '$CONFIG'"
When run bash -c "awk '/id = \"Tray\";/{in_tray=1} in_tray && /^ }/{exit} in_tray{print}' '$CONFIG'"
The output should include 'colorizeIcons = false;'
The output should include 'drawerEnabled = false;'
Comment on lines 12 to 15

@coderabbitai coderabbitai Bot May 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Tray spec asserts the wrong target behavior.

Line 14 expects colorizeIcons = false;, which contradicts the PR objective to colorize tray icons. This test will enforce the wrong config.

Suggested fix 
 It 'shows tray items inline instead of hiding them in the drawer'
 When run bash -c "awk '/id = \"Tray\";/{in_tray=1} in_tray && /^          }/{exit} in_tray{print}' '$CONFIG'"
-The output should include 'colorizeIcons = false;'
+The output should include 'colorizeIcons = true;'
 The output should include 'drawerEnabled = false;'
 End
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
It 'shows tray items inline instead of hiding them in the drawer'
When run bash -c "awk '/id = \"Tray\";/{in_tray=1} in_tray && /drawerEnabled = false;/{print; exit}' '$CONFIG'"
When run bash -c "awk '/id = \"Tray\";/{in_tray=1} in_tray && /^ }/{exit} in_tray{print}' '$CONFIG'"
The output should include 'colorizeIcons = false;'
The output should include 'drawerEnabled = false;'
It 'shows tray items inline instead of hiding them in the drawer'
When run bash -c "awk '/id = \"Tray\";/{in_tray=1} in_tray && /^ }/{exit} in_tray{print}' '$CONFIG'"
The output should include 'colorizeIcons = true;'
The output should include 'drawerEnabled = false;'
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@spec/noctalia_bar_spec.sh` around lines 12 - 15, The spec "It 'shows tray
items inline instead of hiding them in the drawer'" asserts the wrong value for
tray icon colorization — replace the expectation for the string 'colorizeIcons =
false;' with 'colorizeIcons = true;' so the test matches the PR's intent to
colorize tray icons; keep the existing 'drawerEnabled = false;' assertion as-is
and ensure the grep/awk target that captures the Tray block (the same block that
yields 'drawerEnabled' and 'colorizeIcons') remains unchanged.

End

It 'keeps active window app icons uncolorized'
When run bash -c "awk '/id = \"ActiveWindow\";/{in_active_window=1} in_active_window && /^ }/{exit} in_active_window{print}' '$CONFIG'"
The output should include 'colorizeIcons = false;'
End

It 'does not duplicate the workspace widget on the left bar'
When run bash -c "awk '/widgets.left = \\[/{in_left=1} in_left && /id =/ {print} in_left && /^ \\];/{exit}' '$CONFIG'"
The output should not include 'Workspace'
Expand Down
Loading